Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Folly, fizz, wangle, proxygen, fbthrift, mvfst] Update to latest version #22967

Merged
merged 40 commits into from
Feb 9, 2022

Conversation

Thomas1664
Copy link
Contributor

@Thomas1664 Thomas1664 commented Feb 6, 2022

Describe the pull request
I updated these ports in a single PR because wangle depends on fizz and fizz depends on folly.
I needed to fix rsocket as well because of an error (see bellow).

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@Thomas1664
Copy link
Contributor Author

Thomas1664 commented Feb 6, 2022

rsocket fails with error:

D:\buildtrees\rsocket\src\84ec7fc921-34939c4083.clean\rsocket\transports\tcp\TcpConnectionAcceptor.cpp(32): error C3668: 'rsocket::TcpConnectionAcceptor::SocketCallback::connectionAccepted': method with override specifier 'override' did not override any base class methods [56/59] C:\PROGRA~2\MICROS~3\2019\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\cl.exe /TP -DBOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE -DDEBUG -DFMT_LOCALE -DFMT_SHARED -DGFLAGS_IS_A_DLL=1 -DGLOG_NO_ABBREVIATED_SEVERITIES -DGOOGLE_GLOG_DLL_DECL=__declspec(dllimport) -DGOOGLE_GLOG_DLL_DECL_FOR_UNITTESTS=__declspec(dllimport) -DNOMINMAX -DWIN32_LEAN_AND_MEAN -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_SCL_SECURE_NO_WARNINGS -D_STL_EXTRA_DISABLED_WARNINGS="4774 4987" -ID:\buildtrees\rsocket\src\84ec7fc921-34939c4083.clean -ID:\buildtrees\rsocket\src\84ec7fc921-34939c4083.clean\yarpl\.. -ID:\installed\x64-windows\include /nologo /DWIN32 /D_WINDOWS /W3 /utf-8 /GR /EHsc /MP /D_DEBUG /MDd /Z7 /Ob0 /Od /RTC1 /EHs /GF /Zc:referenceBinding /Zc:rvalueCast /Zc:implicitNoexcept /Zc:strictStrings /Zc:threadSafeInit /Zc:throwingNew /permissive- /std:c++17 /wd4191 /wd4291 /wd4309 /wd4310 /wd4366 /wd4587 /wd4592 /wd4628 /wd4723 /wd4724 /wd4868 /wd4996 /wd4068 /wd4091 /wd4146 /wd4800 /wd4018 /wd4365 /wd4388 /wd4389 /wd4100 /wd4459 /wd4505 /wd4701 /wd4702 /wd4061 /wd4127 /wd4200 /wd4201 /wd4296 /wd4316 /wd4324 /wd4355 /wd4371 /wd4435 /wd4514 /wd4548 /wd4571 /wd4574 /wd4582 /wd4583 /wd4619 /wd4623 /wd4625 /wd4626 /wd4643 /wd4647 /wd4668 /wd4706 /wd4710 /wd4711 /wd4714 /wd4820 /wd5026 /wd5027 /wd5031 /wd5045 /we4099 /we4129 /we4566 -std:c++17 /showIncludes /FoCMakeFiles\ReactiveSocket.dir\rsocket\transports\tcp\TcpConnectionFactory.cpp.obj /FdCMakeFiles\ReactiveSocket.dir\ReactiveSocket.pdb /FS -c D:\buildtrees\rsocket\src\84ec7fc921-34939c4083.clean\rsocket\transports\tcp\TcpConnectionFactory.cpp

Edit: fixed

@Thomas1664 Thomas1664 changed the title [Folly, fizz, wangle] Update to latest version [Folly, fizz, wangle, proxygen, fbthrift, mvfst] Update to latest version Feb 6, 2022
@JonLiu1993 JonLiu1993 self-assigned this Feb 7, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Feb 7, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/fbthrift/vcpkg.json
  • ports/fizz/vcpkg.json
  • ports/mvfst/vcpkg.json
  • ports/proxygen/vcpkg.json
  • ports/rsocket/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

ports/fizz/vcpkg.json Outdated Show resolved Hide resolved
ports/folly/vcpkg.json Outdated Show resolved Hide resolved
ports/mvfst/vcpkg.json Outdated Show resolved Hide resolved
ports/rsocket/vcpkg.json Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/fbthrift/vcpkg.json
  • ports/fizz/vcpkg.json
  • ports/mvfst/vcpkg.json
  • ports/proxygen/vcpkg.json
  • ports/rsocket/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@JonLiu1993
Copy link
Member

I have tested all features on my local machine

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Feb 9, 2022
@ras0219-msft
Copy link
Contributor

This LGTM, thanks for the major updates!

@ras0219-msft ras0219-msft merged commit 77c11ff into microsoft:master Feb 9, 2022
@Thomas1664 Thomas1664 deleted the folly-fizz-wangle branch February 9, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wangle:x64-linux] build failure [folly] update to v2021.10.04.00
3 participants