Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdformat6] Disable test #22970

Merged
merged 6 commits into from
Feb 8, 2022
Merged

[sdformat6] Disable test #22970

merged 6 commits into from
Feb 8, 2022

Conversation

JackBoosY
Copy link
Contributor

Fixes

FAILED: test/integration/INTEGRATION_locale_fix.exe 
cmd.exe /C "cd . && D:\downloads\tools\cmake-3.21.1-windows\cmake-3.21.1-windows-i386\bin\cmake.exe -E vs_link_exe --intdir=test\integration\CMakeFiles\INTEGRATION_locale_fix.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100190~1.0\x64\mt.exe --manifests  -- C:\PROGRA~2\MICROS~3\2019\ENTERP~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\link.exe  test\integration\CMakeFiles\INTEGRATION_locale_fix.dir\locale_fix.cc.obj test\integration\CMakeFiles\INTEGRATION_locale_fix.dir\__\__\src\win\tinyxml\tinystr.cpp.obj test\integration\CMakeFiles\INTEGRATION_locale_fix.dir\__\__\src\win\tinyxml\tinyxmlerror.cpp.obj test\integration\CMakeFiles\INTEGRATION_locale_fix.dir\__\__\src\win\tinyxml\tinyxml.cpp.obj test\integration\CMakeFiles\INTEGRATION_locale_fix.dir\__\__\src\win\tinyxml\tinyxmlparser.cpp.obj  /out:test\integration\INTEGRATION_locale_fix.exe /implib:test\integration\INTEGRATION_locale_fix.lib /pdb:test\integration\INTEGRATION_locale_fix.pdb /version:0.0 /nologo /DEBUG /INCREMENTAL:NO /OPT:REF /OPT:ICF   /subsystem:console -LIBPATH:D:\buildtrees\sdformat6\x64-windows-rel\src   -LIBPATH:D:\buildtrees\sdformat6\x64-windows-rel\test gtest.lib  gtest_main.lib  sdformat.lib  D:\installed\x64-windows\lib\ignition-math4.lib  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cmd.exe /C "cd /D D:\buildtrees\sdformat6\x64-windows-rel\test\integration && D:\downloads\tools\cmake-3.21.1-windows\cmake-3.21.1-windows-i386\bin\cmake.exe -E copy_if_different D:/buildtrees/sdformat6/x64-windows-rel/src/sdformat.dll D:/buildtrees/sdformat6/x64-windows-rel/test/integration""
Error copying file (if different) from "D:/buildtrees/sdformat6/x64-windows-rel/src/sdformat.dll" to "D:/buildtrees/sdformat6/x64-windows-rel/test/integration".

Related: #22676.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Feb 7, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Feb 7, 2022
JackBoosY
JackBoosY commented Feb 7, 2022
View reviewed changes
ports/sdformat6/fix-dependency-urdfdom.patch
if (NOT DEFINED USE_INTERNAL_URDF OR NOT USE_INTERNAL_URDF)
# check for urdfdom with pkg-config
- pkg_check_modules(URDF urdfdom>=1.0)
+ find_package(urdfdom CONFIG REQUIRED)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now urdfdom doesn't provide pkgconfig in vcpkg.

@ras0219-msft ras0219-msft merged commit 6427bc6 into microsoft:master Feb 8, 2022
@ras0219-msft
Copy link
Contributor

This LGTM, thanks!

@JackBoosY JackBoosY deleted the dev/jack/disable-sdformat6-test branch February 8, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions approved these changes

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JackBoosY @ras0219-msft @LilyWangLL