Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[restclient-cpp] update to master #23005

Merged
merged 4 commits into from
Feb 10, 2022

Conversation

JonLiu1993
Copy link
Member

Fix #22888

Update restclient-cpp to the latest commit

Note: no feature need to test

@JonLiu1993 JonLiu1993 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Feb 9, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/restclient-cpp/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@JonLiu1993 JonLiu1993 marked this pull request as ready for review February 9, 2022 05:37
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Feb 10, 2022
@ras0219-msft ras0219-msft merged commit 9e3638b into microsoft:master Feb 10, 2022
@ras0219-msft
Copy link
Contributor

This seems reasonable to me given that the project is semi-abandoned and is unlikely to publish a new release any time soon.

However, this also means that the project is likely to be removed if it would prevent another dependency from updating (curl).

@JonLiu1993 JonLiu1993 deleted the dev/Jon/restclient-cpp branch February 11, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mrtazz/restclient-cpp] update to master
3 participants