[cairo] fix accidental dependency on system libbfd #23022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JonLiu1993
added
the
category:port-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/cairo/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
|
@DarthGandalf ,Thanks for your pr, could you please sign CLA first? |
|
Done |
JonLiu1993
approved these changes
Feb 11, 2022
JonLiu1993
added
info:reviewed
JonLiu1993
added
requires:author-response
and removed
info:reviewed
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/cairo/vcpkg.json
Valid values for the license field can be found in the documentation
JonLiu1993
approved these changes
Feb 17, 2022
SchaichAlonso
pushed a commit
to PurpleFlowerGarden/vcpkg
that referenced
this pull request
Mar 30, 2022
Upstream has introduced an option to disable bfd. Use the option to disable it (See microsoft#23022)
dan-shaw
pushed a commit
that referenced
this pull request
Apr 1, 2022
* [cairo] upgrade cairo to 1.7.6 (#23848) * [cairo] remove patch (#23848) 0001-meson-fix-macOS-build-and-add-macOS-ci.patch has been merged into the upstream repository and is part of the 1.7.6 release. * [cairo] use meson option to disable bfd (#23848) Upstream has introduced an option to disable bfd. Use the option to disable it (See #23022) * [cairo] chase upstream cflags handling (#23848) Upstream has put all cflags handling into the top-level meson. Move our static compilation indicator definition to the top level, too. * [cairo] force-disable xcb (#23848) This is the next update * [cairo] format vcpkg.json (#23848) * [cairo] update version registries (#23848) * [cairo] add license (#23848) * [cairo] regenerate versions registry (#23848) Co-authored-by: Schaich <alonso.schaich@sodgeit.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
The build was broken if the system has bfd installed, it tried to use /usr/include/x86_64-pc-linux-gnu/bfd.h which in turn complained that "config.h" was not included.
Which triplets are supported/not supported? Have you updated the CI baseline?
tested on x64-linux, and yes
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
yes./vcpkg x-add-version --alland committed the result?If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/