Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ao] Add new port libao #23031

Merged
merged 14 commits into from
Feb 18, 2022
Merged

[ao] Add new port libao #23031

merged 14 commits into from
Feb 18, 2022

Conversation

xiaoyifang
Copy link
Contributor

Describe the pull request
#21791

  • What does your PR fix?

add libao port

  • Which triplets are supported/not supported? Have you updated the CI baseline?

windows,

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@ghost
Copy link

ghost commented Feb 10, 2022

CLA assistant check
All CLA requirements met.

@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 11, 2022
@LilyWangLL LilyWangLL changed the title [New port]ao: add libao windows port [ao] Add new port libao Feb 11, 2022
ports/ao/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangLL
Copy link
Contributor

Please run command vcpkg x-add-version --all then commit the changes.

xiaoyifang and others added 2 commits February 11, 2022 11:18
Co-authored-by: LilyWangLL <94091114+LilyWangLL@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/ao/vcpkg.json

Valid values for the license field can be found in the documentation

@LilyWangLL
Copy link
Contributor

LilyWangLL commented Feb 11, 2022

There are error on Linux:

Include files should not be duplicated into the /debug/include directory. If this cannot be disabled in the project cmake, use
    file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include")

Could you please fix this error?

@xiaoyifang
Copy link
Contributor Author

xiaoyifang commented Feb 11, 2022

There are error on Linux:

Include files should not be duplicated into the /debug/include directory. If this cannot be disabled in the project cmake, use
    file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include")

Could you please fix this error?

I do not intended it run in linux , can I just disabled the linux build

ports/ao/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangLL
Copy link
Contributor

Ao build failed on UWP with the following error:

     4>D:\buildtrees\ao\src\1.2.2-ef2f813c3f.clean\src\audio_out.c(654,26): error C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\buildtrees\ao\x64-uwp-dbg\ao.vcxproj]
     4>D:\buildtrees\ao\src\1.2.2-ef2f813c3f.clean\src\audio_out.c(655,17): error C4996: 'strcat': This function or variable may be unsafe. Consider using strcat_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\buildtrees\ao\x64-uwp-dbg\ao.vcxproj]

Co-authored-by: LilyWangLL <94091114+LilyWangLL@users.noreply.github.com>
@xiaoyifang
Copy link
Contributor Author

what about just disable it with supports field in vcpkg.json

@LilyWangLL LilyWangLL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Feb 14, 2022
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Under normal circumstances we would not accept new libraries with such short names, however due to libao's maturity and renown I believe it is acceptable to use libao in this case.

ports/ao/0001-windows-build-patch.patch Outdated Show resolved Hide resolved
ports/ao/portfile.cmake Outdated Show resolved Hide resolved
ports/ao/vcpkg.json Outdated Show resolved Hide resolved
@BillyONeal BillyONeal removed the info:reviewed Pull Request changes follow basic guidelines label Feb 16, 2022
@xiaoyifang
Copy link
Contributor Author

normally ,when will this be merge?

@LilyWangLL LilyWangLL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Feb 18, 2022
@vicroms vicroms merged commit 1604b06 into microsoft:master Feb 18, 2022
@xiaoyifang
Copy link
Contributor Author

can not be searched in the following website
https://vcpkg.io/en/packages.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants