[google-cloud-cpp] add new features #23056
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
I tested the new (and old) features locally, on Linux only. |
| "host": true | ||
| }, | ||
| "protobuf", | ||
| { |
There was a problem hiding this comment.
While it doesn't harm anything, I don't think this host dependency on protobuf has any effect. I see that the portfile does do
vcpkg_add_to_path(PREPEND "${CURRENT_HOST_INSTALLED_DIR}/tools/grpc")but it seems that any host version of protobuf must be being pulled in via some other mechanism (which should itself express that dependency).
There was a problem hiding this comment.
Interesting. I am Okay merging as-is. We will be adding more features in the next few weeks and that should give me plenty of motivation to make these things smaller.
Meanwhile: google-cloud-cpp depends both directly and indirectly on Protobuf. What is the recommended practice in such cases?
Just rely on the indirect dependency? For stable libraries that seems Okay, but it is prone to breaking a leaf if an intermediate dependency drops an ancestor dep.
Or are you saying that google-cloud-cpp already is taking advantage of the indirect dependency? If so, should I make other changes to express the direct dependency better?
There was a problem hiding this comment.
What I mean is that it appears there is a direct dependency only on the target variant, not on the host variant. This is in contrast to grpc which clearly has a direct dependency on the host variant (based on the use of CURRENT_HOST_INSTALLED_DIR). Therefore I was suggesting that the host variant of protobuf be removed from the list since any dependency on it is an indirect dependency. It should be handled elsewhere by the component that has it as a direct dependency.
JonLiu1993
added
the
category:port-feature
|
All features are tested successfully in the following triplet:
|
JonLiu1993
added
info:reviewed
[google-cloud-cpp] add new features (microsoft#23056)
Add two new GA features in
google-cloud-cpp.What does your PR fix?
N/A
Which triplets are supported/not supported? Have you updated the CI baseline?
No change
Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes.