[fribidi] Fix cross-compilation in meson. Re-enable arm64-windows. #23063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/fribidi/vcpkg.json
Valid values for the license field can be found in the documentation
LilyWangLL
requested changes
Feb 14, 2022
LilyWangLL
added
category:port-bug
ras0219-msft
force-pushed
the
dev/roschuma/fribidi
branch
from
67209e3
to
8c707e1
Compare
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/fribidi/vcpkg.json
Valid values for the license field can be found in the documentation
LilyWangLL
approved these changes
Feb 16, 2022
LilyWangLL
added
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buildsystem revert back to autoconf in #21948 did not actually fix cross-compilation; rather it just allowed the build to stumble forward hoping that the cross-built executables would run.
This PR actually fixes cross-compilation by adding a proper host dependency and reusing the tables generated from that host build.
This PR is specifically in pursuit of reenabling ffmpeg:arm64-windows.