Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libtins] Fix bug in portfile.cmake #23150

Merged

Conversation

yonatanbk
Copy link
Contributor

@yonatanbk yonatanbk commented Feb 17, 2022

Fix bug in libtiins portfile.cmake.

  • What does your PR fix?

    Fixes #... bug while cmake install libtins library

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    <all / linux, windows, ...>, <Yes/No>
    all, yes

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yes

@JackBoosY JackBoosY self-assigned this Feb 17, 2022
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Feb 17, 2022
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the port version. See documentation.
Also please run command vcpkg x-add-version --all then commit the changes.

@ghost
Copy link

ghost commented Feb 17, 2022

CLA assistant check
All CLA requirements met.

@yonatanbk
Copy link
Contributor Author

port version bumped

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout f54a7b00130e54a398e9c852d200616b670e991c -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/l-/libtins.json b/versions/l-/libtins.json
index 64701ff..d81d747 100644
--- a/versions/l-/libtins.json
+++ b/versions/l-/libtins.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "b9f8ba13a13acb8f2b769dfb8aab279f59358642",
+      "git-tree": "4a1470befea5c6b5c7418f9b85f37d6f8733d7d5",
       "version": "4.3",
       "port-version": 6
     },

versions/l-/libtins.json Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Feb 18, 2022
@vicroms vicroms merged commit 2934628 into microsoft:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants