Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yajl] Update REF and SHA512 #23157

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Conversation

JackBoosY
Copy link
Contributor

Fixes #23147.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Feb 18, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/yajl/portfile.cmake

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Feb 18, 2022
@vadi2
Copy link
Contributor

vadi2 commented Feb 18, 2022

I can confirm the port builds fine now. Thanks for updating it as well.

  Starting package 8/8: yajl:x64-linux
  Building package yajl[core]:x64-linux...
  -- Downloading https://github.com/lloyd/yajl/archive/a0ecdde0c042b9256170f2f8890dd9451a4240aa.tar.gz -> lloyd-yajl-a0ecdde0c042b9256170f2f8890dd9451a4240aa.tar.gz...
  -- Extracting source /home/runner/work/Mudlet/Mudlet/3rdparty/vcpkg/downloads/lloyd-yajl-a0ecdde0c042b9256170f2f8890dd9451a4240aa.tar.gz
  -- Applying patch cmake.patch
  -- Using source at /home/runner/work/Mudlet/Mudlet/3rdparty/vcpkg/buildtrees/yajl/src/451a4240aa-f4cc4f5ebb.clean
  -- Found external ninja('1.10.2').
  -- Configuring x64-linux-dbg
  -- Configuring x64-linux-rel
  -- Building x64-linux-dbg
  -- Building x64-linux-rel
  -- Fixing pkgconfig file: /home/runner/work/Mudlet/Mudlet/3rdparty/vcpkg/packages/yajl_x64-linux/lib/pkgconfig/yajl.pc
  -- Fixing pkgconfig file: /home/runner/work/Mudlet/Mudlet/3rdparty/vcpkg/packages/yajl_x64-linux/debug/lib/pkgconfig/yajl.pc
  -- Installing: /home/runner/work/Mudlet/Mudlet/3rdparty/vcpkg/packages/yajl_x64-linux/share/yajl/copyright
  -- Performing post-build validation
  -- Performing post-build validation done
  Stored binary cache: /home/runner/.cache/vcpkg/archives/3e/3e6e95905275a924946c06925cff0167c45f841ab218113b2b1b8785854e1e71.zip
  Installing package yajl[core]:x64-linux...
  Elapsed time for package yajl:x64-linux: 3.036 s

@vicroms vicroms merged commit 53586bf into microsoft:master Feb 18, 2022
@JackBoosY JackBoosY deleted the dev/jack/23147 branch February 21, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[yajl] macos & linux build failure
4 participants