[cmake-user] Disable CI test with CMake 3.4 #23168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
scripts/test_ports/cmake-user/vcpkg.json
Valid values for the license field can be found in the documentation
|
CC @BillyONeal |
|
This LGTM as a temporary hotfix, agreed that we need to reenable it with the new minimum. Thanks! |
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Feb 18, 2022
[cmake-user] Disable CI test with CMake 3.4 (microsoft#23168)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Quick fix for CI errors for ports which trigger the explicit CMake 3.4 test in port cmake-user. E.g. [boost-modular-build-helper] Attempt to pass flags more correctly into b2 #23001, [liblzma] No debug postfix. Rewrite wrapper. #22856.
(The proper fix is switching to CMake 3.7.2, but this can be done in another PR.)
Which triplets are supported/not supported? Have you updated the [CI baseline]
all, no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?test port