-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proj, proj4] Update to PROJ 9.0.0 & make proj the regular port #23186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libgeotiff/vcpkg.json
ports/libosmium/vcpkg.json
ports/libspatialite/vcpkg.json
ports/vtk/vcpkg.json
Valid values for the license field can be found in the documentation
Also please resolve this PR's conflicts. Thanks. |
I will resolve the conflicts with the official release which we can expect today. |
There are some most likely unrelated 7zip errors on x64_uwp and arm64 builds now? |
Entirely unrelated: #23284 |
"port-version": 1, | ||
"description": "PROJ library for cartographic projections", | ||
"homepage": "https://proj.org/", | ||
"version-semver": "8.9.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version-semver": "8.9.9", | |
"version": "8.9.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why?
I would expect server to have stricter rules than plain version, so to be slightly better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We prefer relaxed version unless upstream explicitly states that they follow semver strictly.
I admit, it doesn't matter much here since we don't expect to keep updating the proj4
port.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intentional.
AFAIU we need to keep the version scheme to have an upgrade path with a version number which compares greater-than to the previous version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, a while ago we made changes to how we treat version
and version-semver
during version resolution so it shouldn't matter anymore. We need to update our docs to catch-up with current implementation.
Can you please resolve the file conflicts? Thanks. |
Can this be merged soon? New releases for libgeotiff and gdal are coming, and I'm tired of merge conflicts from versioning meta data. |
Ping @vicroms @BillyONeal for merge this quickly. |
What does your PR fix?
Updates to PROJ 9.0.0.
Makes proj the regular port instead of proj4.
Moves cmake config to lower-case folders, and data into a subfolder.
Which triplets are supported/not supported? Have you updated the CI baseline?
all, no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes