[lmdb] don't use msvc parameters with non-msvc compiler #23653

bold84 · 2022-03-19T07:52:00Z

Describe the pull request

What does your PR fix?

Fixes failed build on non-windows-dynamic
Which triplets are supported/not supported? Have you updated the CI baseline?

<all / linux, windows, ...>, <Yes/No>
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

ports/lmdb/vcpkg.json

Thomas1664 · 2022-03-19T11:19:28Z

versions/l-/lmdb.json

+      "git-tree": "5ed5bd2c01a6c4467f9be85807e7727666ddb5b7",
+      "version": "0.9.24",


please revert this and run vcpkg x-add-version lmdb again after you committed this and the other changes.

Thomas1664 · 2022-03-19T11:19:52Z

ports/lmdb/cmake/CMakeLists.txt

@@ -20,8 +20,8 @@ set(LMDB_LIBRARY_INSTALL_DIR lib CACHE PATH "Install directory for library")
 set(LMDB_RUNTIME_INSTALL_DIR bin CACHE PATH "Install directory for binaries/dlls")
 set(LMDB_CONFIG_INSTALL_DIR share/lmdb CACHE PATH "Install directory for cmake config files")

-
-if(BUILD_SHARED_LIBS)
+message("Compiler: ${CMAKE_CXX_COMPILER_ID}")


Why is this message needed?

It isn't. Forgot to remove it...

JonLiu1993 · 2022-03-21T06:58:20Z

@bold84 ,Thanks for your pr, please consider @Thomas1664's review suggesstion

bold84 · 2022-03-25T04:08:41Z

@bold84 ,Thanks for your pr, please consider @Thomas1664's review suggesstion

Sure, it's just a pita that for a one line code change, it is required to do these version things that I have not found documentation for. Where is this version stuff documented?

For another PR previously, I was not supposed to increase the version. But for this one it seems it's required.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout a76eb002a71b6cf7bad343f5e3376dfe6bb83c5c -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/lmdb.json b/versions/l-/lmdb.json
index 876c69c..b92ae50 100644
--- a/versions/l-/lmdb.json
+++ b/versions/l-/lmdb.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "e6ffab6abd2f4953adaf29622af857fab8dbd359",
+      "git-tree": "9af408cdb98ca24cfe075eacc661172c2be53a0f",
       "version": "0.9.24",
       "port-version": 2
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/lmdb/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/lmdb/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff

diff --git a/ports/lmdb/vcpkg.json b/ports/lmdb/vcpkg.json
index ed3f84a..2c2b590 100644
--- a/ports/lmdb/vcpkg.json
+++ b/ports/lmdb/vcpkg.json
@@ -3,6 +3,6 @@
   "version": "0.9.24",
   "port-version": 2,
   "description": "LMDB is an extraordinarily fast, memory-efficient database",
-  "license": null,
-  "homepage": "https://github.com/LMDB/lmdb"
+  "homepage": "https://github.com/LMDB/lmdb",
+  "license": null
 }

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout a76eb002a71b6cf7bad343f5e3376dfe6bb83c5c -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/lmdb.json b/versions/l-/lmdb.json
index b92ae50..5166dd8 100644
--- a/versions/l-/lmdb.json
+++ b/versions/l-/lmdb.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "9af408cdb98ca24cfe075eacc661172c2be53a0f",
+      "git-tree": "022fa44ff8c5ef9ea4b308468259c0775d4a72c1",
       "version": "0.9.24",
       "port-version": 2
     },

* master: (103 commits) [lmdb] don't use msvc parameters with non-msvc compiler (microsoft#23653) Fix <version> of Python in vcpkgTools.xml (microsoft#23751) [sciter] escape quotes (microsoft#23752) [fuzzylite] Fix Linux build (microsoft#23658) [cpp-redis] Fix ‘sleep_for’ is not a member of ‘std::this_thread’ (microsoft#23762) [nlohmann-json] Fix usage text (microsoft#23749) [fontconfig] Do not create symlinks (microsoft#23735) (microsoft#23736) [winsparkle] Fix header file and debug path (microsoft#23739) [arb] Support dynamic build (microsoft#23743) [aws-sdk-cpp] update to 1.9.220 (microsoft#23729) Fix the VS2022 'unstable' queues. (microsoft#23742) [xmlsec] Bump to 1.2.33 (microsoft#23733) [unicorn] update to latest version v1.0.3 (microsoft#23745) [libpq] Update version to 14.1 2 (microsoft#22516) [libnoise] Export CMake files (microsoft#23682) [vcpk-ci] Trigger some test ports from vcpkg.cmake changes (microsoft#23430) [nlohmann-json] Add option to control implicit conversions behaviour (microsoft#22409) [libjuice] Update to 0.9.8 (microsoft#23153) [libgeotiff] Update to 1.7.1 (microsoft#23446) [minizip-ng] Updated minizip version and fixed windows build for previous version (microsoft#23684) ...

don't use msvc parameters with non-msvc compiler

b9273bb

bold84 changed the title ~~don't use msvc parameters with non-msvc compiler~~ [lmdb] don't use msvc parameters with non-msvc compiler Mar 19, 2022

Thomas1664 suggested changes Mar 19, 2022

View reviewed changes

Adela0814 assigned JonLiu1993 Mar 21, 2022

JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support requires:author-response labels Mar 21, 2022

bold84 added 2 commits March 24, 2022 21:24

change condition

7ff5208

Update version

7448ea7

bold84 force-pushed the lmdb_shared_linux_fix branch from 9c60476 to 7448ea7 Compare March 25, 2022 04:31

github-actions bot requested changes Mar 25, 2022

View reviewed changes

add license field

a28f967

github-actions bot approved these changes Mar 25, 2022

View reviewed changes

updated the license field

784c592

github-actions bot requested changes Mar 25, 2022

View reviewed changes

bold84 added 2 commits March 24, 2022 21:47

formatted the manifest file.

9596966

updated version

68d2d57

github-actions bot approved these changes Mar 25, 2022

View reviewed changes

Merge branch 'microsoft:master' into lmdb_shared_linux_fix

0474a4d

github-actions bot approved these changes Mar 25, 2022

View reviewed changes

Thomas1664 approved these changes Mar 25, 2022

View reviewed changes

JonLiu1993 approved these changes Mar 25, 2022

View reviewed changes

JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 25, 2022

dan-shaw merged commit a95ee82 into microsoft:master Mar 25, 2022

bold84 deleted the lmdb_shared_linux_fix branch April 17, 2022 23:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[lmdb] don't use msvc parameters with non-msvc compiler #23653

[lmdb] don't use msvc parameters with non-msvc compiler #23653

bold84 commented Mar 19, 2022

Thomas1664 Mar 19, 2022

Thomas1664 Mar 19, 2022

bold84 Mar 19, 2022 •

edited

Loading

JonLiu1993 commented Mar 21, 2022

bold84 commented Mar 25, 2022 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

		"git-tree": "5ed5bd2c01a6c4467f9be85807e7727666ddb5b7",
		"version": "0.9.24",

[lmdb] don't use msvc parameters with non-msvc compiler #23653

[lmdb] don't use msvc parameters with non-msvc compiler #23653

Conversation

bold84 commented Mar 19, 2022

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Thomas1664 Mar 19, 2022

Choose a reason for hiding this comment

Thomas1664 Mar 19, 2022

Choose a reason for hiding this comment

bold84 Mar 19, 2022 • edited Loading

Choose a reason for hiding this comment

JonLiu1993 commented Mar 21, 2022

bold84 commented Mar 25, 2022 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

bold84 Mar 19, 2022 •

edited

Loading

bold84 commented Mar 25, 2022 •

edited

Loading