New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mailio] correct hint #23799
[mailio] correct hint #23799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/mailio/portfile.cmake
Could the mailio cmake config be found at all, before this change? |
Thanks for your PR, |
ports/mailio/portfile.cmake
Outdated
@@ -17,6 +17,11 @@ vcpkg_cmake_configure( | |||
) | |||
vcpkg_cmake_install() | |||
|
|||
vcpkg_fixup_cmake_targets( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This legacy function has been replaced by vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also need add dependency vcpkg-cmake-config
in vcpkg.json.
@LilyWangLL I just saw this MR #23772 that contain some of these fixes. Maybe you can accept first that MR and then update this one if something is missing. |
I think PR #23772 can closed and its fix can merged to this PR, it just add |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 9ff4659a075d5f4f30aaca9f7c4e7f059ecc1d6d -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/m-/mailio.json b/versions/m-/mailio.json
index dab3280..1fdf4c1 100644
--- a/versions/m-/mailio.json
+++ b/versions/m-/mailio.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "61b298737570de13efc96c3427220b8146140526",
+ "git-tree": "72c0f040b1fbad74b2e6ff069d1dcf996233ef16",
"version": "0.21.0",
"port-version": 1
},
Hi @david-antiteum, can you please resolve the conflicts against master? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for mailio but no changes to version or port version.
-- Version: 0.21.0#1
-- Old SHA: 80186942edc09cad3c911ebbc6dd77d30af68502
-- New SHA: f0fde0f6599aacd2b890c94326f504bf2af8f642
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 773516ecf6014d89cc69b11bb54605ad4be56694 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/m-/mailio.json b/versions/m-/mailio.json
index 1fdf4c1..571caa9 100644
--- a/versions/m-/mailio.json
+++ b/versions/m-/mailio.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "72c0f040b1fbad74b2e6ff069d1dcf996233ef16",
+ "git-tree": "80186942edc09cad3c911ebbc6dd77d30af68502",
"version": "0.21.0",
"port-version": 1
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for mailio but no changes to version or port version.
-- Version: 0.21.0#1
-- Old SHA: 80186942edc09cad3c911ebbc6dd77d30af68502
-- New SHA: f0fde0f6599aacd2b890c94326f504bf2af8f642
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 773516ecf6014d89cc69b11bb54605ad4be56694 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/m-/mailio.json b/versions/m-/mailio.json
index e96c42b..571caa9 100644
--- a/versions/m-/mailio.json
+++ b/versions/m-/mailio.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "f0fde0f6599aacd2b890c94326f504bf2af8f642",
+ "git-tree": "80186942edc09cad3c911ebbc6dd77d30af68502",
"version": "0.21.0",
"port-version": 1
},
@david-antiteum Please update |
required after merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 773516ecf6014d89cc69b11bb54605ad4be56694 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/m-/mailio.json b/versions/m-/mailio.json
index fe4eba4..7cf1089 100644
--- a/versions/m-/mailio.json
+++ b/versions/m-/mailio.json
@@ -6,7 +6,7 @@
"port-version": 2
},
{
- "git-tree": "f0fde0f6599aacd2b890c94326f504bf2af8f642",
+ "git-tree": "80186942edc09cad3c911ebbc6dd77d30af68502",
"version": "0.21.0",
"port-version": 1
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 773516ecf6014d89cc69b11bb54605ad4be56694 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/m-/mailio.json b/versions/m-/mailio.json
index 156df34..5051932 100644
--- a/versions/m-/mailio.json
+++ b/versions/m-/mailio.json
@@ -6,7 +6,7 @@
"port-version": 2
},
{
- "git-tree": "f0fde0f6599aacd2b890c94326f504bf2af8f642",
+ "git-tree": "80186942edc09cad3c911ebbc6dd77d30af68502",
"version": "0.21.0",
"port-version": 1
},
Thanks! |
What does your PR fix?
Fixes [mailio] hint message after installing mailio is incorrect #23798