Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][quickfix] Remove from CI baseline #23878

Merged
merged 6 commits into from
Apr 1, 2022

Conversation

Thomas1664
Copy link
Contributor

@Thomas1664 Thomas1664 commented Mar 30, 2022

Describe the pull request

  • What does your PR fix?

    Remove quickfix for passing triplets from CI baseline
    Fix deprecated CMake
    Remove trailing whitespaces in templates/portfile.in.cmake (Included in this PR since it's a one-liner)

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Yes, removed all Windows triplets (except UWP) from CI baseline

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

Note that the purpose of this PR is to resolve baseline issues. This PR doesn't attempt to fix any other issues the port might have.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/quickfix/vcpkg.json

Valid values for the license field can be found in the documentation

@dg0yt
Copy link
Contributor

dg0yt commented Mar 30, 2022

Note that the purpose of this PR is to resolve baseline issues. This PR doesn't attempt to fix any other issues the port might have.

AFAICS that the problem is that the PR CI shouldn't build ports which are marked "fail". At least this was the behavior until recently. Cf. #23862.

@Thomas1664
Copy link
Contributor Author

AFAICS that the problem is that the PR CI shouldn't build ports which are marked "fail". At least this was the behavior until recently. Cf. #23862.

I know.

@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Mar 31, 2022
@JackBoosY JackBoosY changed the title [quickfix] Remove from CI baseline [vcpkg baseline][quickfix] Remove from CI baseline Apr 1, 2022
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Apr 1, 2022
scripts/ci.baseline.txt Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/quickfix/vcpkg.json

Valid values for the license field can be found in the documentation

@BillyONeal
Copy link
Member

Thank you <3

@BillyONeal BillyONeal merged commit 27fd32e into microsoft:master Apr 1, 2022
@Thomas1664 Thomas1664 deleted the quickfix branch April 1, 2022 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants