[wxcharts] Add new port #24263

playgithub · 2022-04-20T07:33:46Z

Describe the pull request

What does your PR fix?

Port https://github.com/wxIshiko/wxCharts
Which triplets are supported/not supported? Have you updated the [CI baseline]

All
Does your PR follow the [maintainer guide]

Not sure
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for wxcharts but no changes to version or port version.
-- Version: 0.1.0
-- Old SHA: ccb95d41def248b9409d4edf8e97dbef06682830
-- New SHA: 1201cfb1e31e3983a8a353080569401ff0c1416a
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

ports/wxcharts/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for wxcharts but no changes to version or port version.
-- Version: 0.1.0
-- Old SHA: 1201cfb1e31e3983a8a353080569401ff0c1416a
-- New SHA: 9fb35aaf475a80255e7bd734802fdfcf32444961
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for wxcharts but no changes to version or port version.
-- Version: 0.1.0
-- Old SHA: 1201cfb1e31e3983a8a353080569401ff0c1416a
-- New SHA: e89549c019ea78cc536a33c5374a3c02fa5e1ce9
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

ports/wxcharts/portfile.cmake

ports/wxcharts/support-cmake-and-dll.patch

vcpkg_from_github instead of vcpkg_from_git Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for wxcharts but no changes to version or port version.
-- Version: 0.1.0
-- Old SHA: e89549c019ea78cc536a33c5374a3c02fa5e1ce9
-- New SHA: b7e7e6cf57a9e250a3ce0961113cce4eecd94ad7
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for wxcharts but no changes to version or port version.
-- Version: 0.1.0
-- Old SHA: e89549c019ea78cc536a33c5374a3c02fa5e1ce9
-- New SHA: bf9f07f5584e8270a5897845d04f34bf16ce4a14
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for wxcharts but no changes to version or port version.
-- Version: 0.1.0
-- Old SHA: e89549c019ea78cc536a33c5374a3c02fa5e1ce9
-- New SHA: e8a85b457381b93137cfa42b9fa74b5cefb9b20a
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

ports/wxcharts/portfile.cmake

strega-nil-ms · 2022-04-22T20:39:32Z

Thanks!

ports/wxcharts/vcpkg.json

Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout c37cc7836a0e1cfd55747be8ec472eafa8055276 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index f55511a..e7e8b85 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7513,7 +7513,7 @@
       "port-version": 1
     },
     "wxcharts": {
-      "baseline": "0.1.0",
+      "baseline": "2022-04-22",
       "port-version": 0
     },
     "wxwidgets": {
diff --git a/versions/w-/wxcharts.json b/versions/w-/wxcharts.json
index 23ff0e3..9a9b07f 100644
--- a/versions/w-/wxcharts.json
+++ b/versions/w-/wxcharts.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "b1e9c16349a281b499d1ff50cdee4dd21c4aafec",
+      "version-date": "2022-04-22",
+      "port-version": 0
+    },
     {
       "git-tree": "4f0f72e8dec820b6e4abd6aff086056287285aa3",
       "version": "0.1.0",

versions/w-/wxcharts.json

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

BillyONeal · 2022-04-25T22:45:19Z

Thanks for the new port!

abc added 2 commits April 20, 2022 15:14

port wxcharts

be14802

regulate

3b01473

github-actions bot requested changes Apr 20, 2022

View reviewed changes

add license in vcpkg.json

fae4b75

JonLiu1993 changed the title ~~port wxcharts~~ [wxcharts] Add new port Apr 20, 2022

JonLiu1993 self-assigned this Apr 20, 2022

JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 20, 2022

github-actions bot requested changes Apr 20, 2022

View reviewed changes

fix url

7baa570

github-actions bot requested changes Apr 20, 2022

View reviewed changes

Update version database

ddbc9f7

github-actions bot approved these changes Apr 20, 2022

View reviewed changes

playgithub marked this pull request as ready for review April 21, 2022 04:13

JonLiu1993 requested changes Apr 21, 2022

View reviewed changes

ports/wxcharts/portfile.cmake Outdated Show resolved Hide resolved

ports/wxcharts/portfile.cmake Outdated Show resolved Hide resolved

ports/wxcharts/support-cmake-and-dll.patch Outdated Show resolved Hide resolved

JonLiu1993 added the requires:author-response label Apr 21, 2022

Update ports/wxcharts/portfile.cmake

afb50b6

vcpkg_from_github instead of vcpkg_from_git Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

github-actions bot requested changes Apr 21, 2022

View reviewed changes

try vcpkg_from_github instead of vcpkg_from_git

3295167

github-actions bot requested changes Apr 21, 2022

View reviewed changes

add hash

8847c95

github-actions bot requested changes Apr 21, 2022

View reviewed changes

abc added 2 commits April 21, 2022 14:51

remove comments

e38f200

Update version database

3f45965

github-actions bot approved these changes Apr 21, 2022

View reviewed changes

playgithub requested a review from JonLiu1993 April 21, 2022 06:57

JonLiu1993 reviewed Apr 21, 2022

View reviewed changes

ports/wxcharts/portfile.cmake Outdated Show resolved Hide resolved

playgithub requested a review from JonLiu1993 April 21, 2022 07:29

JonLiu1993 added depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels Apr 22, 2022

playgithub mentioned this pull request Apr 22, 2022

support cmake and dll wxIshiko/wxCharts#199

Merged

abc added 2 commits April 22, 2022 21:17

the patch has been merged in upstream, no need here

1e88b73

Update version

cac42fe

github-actions bot approved these changes Apr 22, 2022

View reviewed changes

strega-nil-ms reviewed Apr 22, 2022

View reviewed changes

ports/wxcharts/vcpkg.json Outdated Show resolved Hide resolved

strega-nil-ms added requires:author-response and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Apr 22, 2022

Update ports/wxcharts/vcpkg.json

71e3c25

Co-authored-by: nicole mazzuca <83086508+strega-nil-ms@users.noreply.github.com>

github-actions bot requested changes Apr 23, 2022

View reviewed changes

Update version

f92d43b

github-actions bot approved these changes Apr 23, 2022

View reviewed changes

JonLiu1993 reviewed Apr 24, 2022

View reviewed changes

versions/w-/wxcharts.json Outdated Show resolved Hide resolved

Update versions/w-/wxcharts.json

f5f5e67

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

github-actions bot approved these changes Apr 24, 2022

View reviewed changes

JonLiu1993 approved these changes Apr 24, 2022

View reviewed changes

JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Apr 24, 2022

BillyONeal merged commit a2de781 into microsoft:master Apr 25, 2022

playgithub deleted the port-wxcharts branch April 26, 2022 05:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wxcharts] Add new port #24263

[wxcharts] Add new port #24263

playgithub commented Apr 20, 2022 •

edited

Loading

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

strega-nil-ms commented Apr 22, 2022

github-actions bot left a comment

BillyONeal commented Apr 25, 2022

[wxcharts] Add new port #24263

[wxcharts] Add new port #24263

Conversation

playgithub commented Apr 20, 2022 • edited Loading

What does your PR fix?

Which triplets are supported/not supported? Have you updated the [CI baseline]

Does your PR follow the [maintainer guide]

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

strega-nil-ms commented Apr 22, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

BillyONeal commented Apr 25, 2022

playgithub commented Apr 20, 2022 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?