Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt5-base]: Fix build with "mysqlplugin" feature by linking to OpenSSL and zlib #24462

Merged

Conversation

davidebeatrici
Copy link
Contributor

Fixes #20817.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for qt5-base but no changes to version or port version.
-- Version: 5.15.3#2
-- Old SHA: abaaa592badf33576f197d915ed1f4ddd91d0931
-- New SHA: 822bf13419cbecb5b09b28f2bbee82e207f345e3
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

@davidebeatrici davidebeatrici changed the title [qt5-base]: Fix build with "mysqlplugin" feature by linking to OpenSS… [qt5-base]: Fix build with "mysqlplugin" feature by linking to OpenSSL and zlib Apr 28, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for qt5-base but no changes to version or port version.
-- Version: 5.15.3#3
-- Old SHA: 822bf13419cbecb5b09b28f2bbee82e207f345e3
-- New SHA: 7518c5eeb84d3bbfaaa88cb19795b693fd0923f7
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

…L and zlib

Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com>
Copy link
Contributor

@silverqx silverqx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this PR fixed the build, the build process finished without errors, thank you 🙌 @davidebeatrici.

I don't know if the static build especially QMYSQL plugin works correctly, but I will test it in the future when I will do next release of my personal library project and let know.

@LilyWangLL LilyWangLL assigned Cheney-W and JackBoosY and unassigned Cheney-W Apr 28, 2022
@davidebeatrici
Copy link
Contributor Author

No problem, thanks for testing!

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Apr 28, 2022
@JackBoosY
Copy link
Contributor

cc @Neumann-A for review this PR.

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Apr 29, 2022
Copy link
Contributor

@silverqx silverqx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillyONeal BillyONeal merged commit 2ece8fe into microsoft:master Apr 29, 2022
@BillyONeal
Copy link
Member

Thanks for the fix!

@davidebeatrici davidebeatrici deleted the qt5-base-mysql-plugin-link-fix branch April 29, 2022 23:19
@davidebeatrici
Copy link
Contributor Author

Thanks for merging!

@silverqx
Copy link
Contributor

Thx guys for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[qt5-base] build failure with mysqlplugin for x64-windows-static
7 participants