[Fluidsynth] add sndfile feature #24635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
FrankXie05
added
the
category:port-feature
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hmoffatt
force-pushed
the
fluidsynth-sndfile
branch
from
99cbf55
to
fcf2f14
Compare
FrankXie05
added
the
requires:all-feature-testing
|
Feature test successfully in the following triplet:
|
FrankXie05
added
info:reviewed
FrankXie05
changed the title
|
I have also tested on arm64-osx and x64-osx. |
FrankXie05
approved these changes
May 11, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Fixes #24619. Add optional feature sndfile to fluidsynth, causing it to be built with libsndfile enabling extra functionality.
Which triplets are supported/not supported? Have you updated the CI baseline?
All triplets supported, no change to baseline
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes