Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openmvs, vcglib] Update openmvs 2.0.1, vcglib 2022.02 #25135

Merged
merged 10 commits into from
Jun 15, 2022

Conversation

longhuan2018
Copy link
Contributor

@longhuan2018 longhuan2018 commented Jun 8, 2022

update openmvs to 2.0.1.
Because a new version of vcglib is required, vcglib is also upgraded.

openmvs Added 2 new features:
nonfree : nonfree support for openmvs
ceres : CERES support for openmvs

For consistency with the original version, nonfree is set as the default feature

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/openmvs/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/openmvs/vcpkg.json
  • ports/vcglib/vcpkg.json

Valid values for the license field can be found in the documentation

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 8, 2022
@JonLiu1993 JonLiu1993 linked an issue Jun 8, 2022 that may be closed by this pull request
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/openmvs/vcpkg.json

Valid values for the license field can be found in the documentation

If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:

  • ports/vcglib/vcpkg.json (has deprecated license GPL-3.0)

Deprecated and non deprecated license identifiers can be found here

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:

  • ports/openmvs/vcpkg.json (has deprecated license GPL-3.0)

Deprecated and non deprecated license identifiers can be found here

@JonLiu1993 JonLiu1993 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 9, 2022
@JonLiu1993 JonLiu1993 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Jun 13, 2022
@JonLiu1993
Copy link
Member

@longhuan2018 ,Thanks for your pr, when I tested the features locally by command "./vcpkg install openmvs[*]:x64-windows" I meet an error :

Compiling with C++17
-- Looking for inttypes.h
-- Looking for inttypes.h - found
-- Found OpenMP_C: -openmp (found version "2.0") 
-- Found OpenMP_CXX: -openmp (found version "2.0") 
-- Found OpenMP: TRUE (found version "2.0")  
-- Found OpenGL: opengl32   
-- Found CUDA: C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v11.2 (found version "11.2") 
-- The CUDA compiler identification is unknown
-- Detecting CUDA compiler ABI info
CMake Error in F:/Feature-test/openmvs/vcpkg/buildtrees/openmvs/x64-windows-rel/CMakeFiles/CMakeTmp/CMakeLists.txt:
  CUDA_ARCHITECTURES is empty for target "cmTC_9d101".


CMake Error in F:/Feature-test/openmvs/vcpkg/buildtrees/openmvs/x64-windows-rel/CMakeFiles/CMakeTmp/CMakeLists.txt:
  CUDA_ARCHITECTURES is empty for target "cmTC_9d101".


CMake Error at F:/Feature-test/openmvs/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/share/cmake-3.22/Modules/CMakeDetermineCompilerABI.cmake:49 (try_compile):
  Failed to generate test project build system.
Call Stack (most recent call first):
  F:/Feature-test/openmvs/vcpkg/downloads/tools/cmake-3.22.2-windows/cmake-3.22.2-windows-i386/share/cmake-3.22/Modules/CMakeTestCUDACompiler.cmake:19 (CMAKE_DETERMINE_COMPILER_ABI)

@longhuan2018
Copy link
Contributor Author

@JonLiu1993 Try entering 'nvcc --version' on the command line to see if CUDA is installed correctly

"C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v11.2/bin/nvcc.exe" --version

@JonLiu1993
Copy link
Member

@JonLiu1993 Try entering 'nvcc --version' on the command line to see if CUDA is installed correctly

"C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v11.2/bin/nvcc.exe" --version

@longhuan2018, do I need to reinstall cuda? If you can provide logs of successful local feature tests, we can also merge

PS F:\Feature-test\openmvs\vcpkg> nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2020 NVIDIA Corporation
Built on Mon_Nov_30_19:15:10_Pacific_Standard_Time_2020
Cuda compilation tools, release 11.2, V11.2.67
Build cuda_11.2.r11.2/compiler.29373293_0

@longhuan2018
Copy link
Contributor Author

Could you send me the 'F:/Feature-test/openmvs/vcpkg/buildtrees/openmvs/x64-windows-rel/CMakeFiles/CMakeOutput.log' file to have a look? @JonLiu1993

@JonLiu1993
Copy link
Member

@longhuan2018 ,Yes, here is it:
CMakeOutput.log
and from CMakeError.log I find this:

CMakeCUDACompilerId.cu
C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.2\include\crt/host_config.h(160): fatal error C1189: #error:  -- unsupported Microsoft Visual Studio version! Only the versions between 2017 and 2019 (inclusive) are supported! The nvcc flag '-allow-unsupported-compiler' can be used to override this version check; however, using an unsupported host compiler may cause compilation failure or incorrect run time execution. Use at your own risk.
# --error 0x2 --

Should I use visual Studio 2019 test?

@longhuan2018
Copy link
Contributor Author

longhuan2018 commented Jun 15, 2022

Yes, you are right. CUDA supports vs2022 from version 11.6. Maybe you can upgrade your CUDA.
image

image

@JonLiu1993
Copy link
Member

All features are tested successfully in the following triplet:

  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Jun 15, 2022
@vicroms vicroms merged commit a175d0a into microsoft:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vcglib] update to 2020.09
3 participants