-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openmvs, vcglib] Update openmvs 2.0.1, vcglib 2022.02 #25135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/openmvs/portfile.cmake
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/openmvs/vcpkg.json
ports/vcglib/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/openmvs/vcpkg.json
Valid values for the license field can be found in the documentation
If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:
ports/vcglib/vcpkg.json
(has deprecated licenseGPL-3.0
)
Deprecated and non deprecated license identifiers can be found here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:
ports/openmvs/vcpkg.json
(has deprecated licenseGPL-3.0
)
Deprecated and non deprecated license identifiers can be found here
@longhuan2018 ,Thanks for your pr, when I tested the features locally by command "./vcpkg install openmvs[*]:x64-windows" I meet an error :
|
@JonLiu1993 Try entering 'nvcc --version' on the command line to see if CUDA is installed correctly
|
@longhuan2018, do I need to reinstall cuda? If you can provide logs of successful local feature tests, we can also merge
|
Could you send me the 'F:/Feature-test/openmvs/vcpkg/buildtrees/openmvs/x64-windows-rel/CMakeFiles/CMakeOutput.log' file to have a look? @JonLiu1993 |
@longhuan2018 ,Yes, here is it:
Should I use visual Studio 2019 test? |
All features are tested successfully in the following triplet:
|
update openmvs to 2.0.1.
Because a new version of vcglib is required, vcglib is also upgraded.
openmvs Added 2 new features:
nonfree : nonfree support for openmvs
ceres : CERES support for openmvs
For consistency with the original version, nonfree is set as the default feature