Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libspatialite] Fix build with VCPKG_BUILD_TYPE=release #25180

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

m-kuhn
Copy link
Contributor

@m-kuhn m-kuhn commented Jun 11, 2022

Describe the pull request

  • What does your PR fix?

    Building libspatialite for a specific VCPKG_BUILD_TYPE only

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ports/libspatialite/portfile.cmake Outdated Show resolved Hide resolved
@m-kuhn m-kuhn force-pushed the libspatialite_release_only branch from 88fd266 to 37c294e Compare June 11, 2022 08:01
@FrankXie05 FrankXie05 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 13, 2022
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Jun 13, 2022
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ras0219-msft ras0219-msft merged commit 70cfcd0 into microsoft:master Jun 13, 2022
@ras0219-msft ras0219-msft changed the title Fix libspatialite build with VCPKG_BUILD_TYPE=release [libspatialite] Fix build with VCPKG_BUILD_TYPE=release Jun 13, 2022
@m-kuhn m-kuhn deleted the libspatialite_release_only branch June 14, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants