Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vk-bootstrap] set missing IMPORTED_LOCATION #25210

Closed
wants to merge 7 commits into from
Closed

[vk-bootstrap] set missing IMPORTED_LOCATION #25210

wants to merge 7 commits into from

Conversation

FrankXie05
Copy link
Contributor

Fix #22067

Note: Set the parameter IMPORTED_LOCATION on the usage of port vk-bootstrap.
Error log:

CMake Warning (dev) in CMakeLists.txt:
  Policy CMP0111 is not set: An imported target missing its location property
  fails during generation.  Run "cmake --help-policy CMP0111" for policy
  details.  Use the cmake_policy command to set the policy and suppress this
  warning.

  IMPORTED_LOCATION not set for imported target "vk-bootstrap::vk-bootstrap".
This warning is for project developers.  Use -Wno-dev to suppress it.

@FrankXie05 FrankXie05 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jun 13, 2022
github-actions[bot]
github-actions bot approved these changes Jun 13, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/vk-bootstrap/vcpkg.json

Valid values for the license field can be found in the documentation

@FrankXie05 FrankXie05 marked this pull request as ready for review June 13, 2022 09:36
@FrankXie05
Copy link
Contributor Author

Turn this PR into a draft.

@FrankXie05 FrankXie05 marked this pull request as draft June 14, 2022 01:31
@FrankXie05 FrankXie05 mentioned this pull request Jun 14, 2022
Closed
@FrankXie05 FrankXie05 added the depends:upstream-changes Waiting on a change to the upstream project label Jun 17, 2022
github-actions[bot]
github-actions bot previously approved these changes Jul 6, 2022
View reviewed changes
@FrankXie05 FrankXie05 removed the depends:upstream-changes Waiting on a change to the upstream project label Jul 8, 2022
@FrankXie05 FrankXie05 marked this pull request as ready for review July 8, 2022 06:52
@FrankXie05 FrankXie05 requested a review from JackBoosY July 8, 2022 06:52
JackBoosY
JackBoosY suggested changes Jul 8, 2022
View reviewed changes
ports/vk-bootstrap/vk-bootstrap-targets-debug.cmake
Comment on lines 9 to +10
IMPORTED_IMPLIB_DEBUG "${_IMPORT_PREFIX}/debug/lib/vk-bootstrap.lib"
IMPORTED_LOCATION "${_IMPORT_PREFIX}/debug/lib/vk-bootstrap.lib"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The origin cmake configurations are all wrong.

vk-bootstrap should supports all the triplet, but there is only Windows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will recheck the cmake configuration of the port

@JonLiu1993
Copy link
Member

Draft this pr because it’s been a long time since any update has been made

@JonLiu1993 JonLiu1993 marked this pull request as draft September 2, 2022 10:20
@JonLiu1993
Copy link
Member

Closing this PR since it seems that no progress is being made. Please ping us to reopen if work is still being done.

@JonLiu1993 JonLiu1993 closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@JackBoosY JackBoosY JackBoosY requested changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[vk-bootstrap] Missing import target when building on Linux
4 participants
@FrankXie05 @JonLiu1993 @dg0yt @JackBoosY