-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hiredis] Fix the conflict of macro ssize_t #25271
[hiredis] Fix the conflict of macro ssize_t #25271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 3d8f78171a2a37d461077bf8d063256b63e25a4f -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index cfa3bca..e4dabec 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2810,7 +2810,7 @@
},
"hiredis": {
"baseline": "1.0.2",
- "port-version": 3
+ "port-version": 4
},
"hps": {
"baseline": "2022-01-18",
diff --git a/versions/h-/hiredis.json b/versions/h-/hiredis.json
index 36c7df6..d641b89 100644
--- a/versions/h-/hiredis.json
+++ b/versions/h-/hiredis.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "61a9442976602c2c980a40ee0ac3206a43bfd748",
+ "version": "1.0.2",
+ "port-version": 4
+ },
{
"git-tree": "4eafe5d23a2d906153cc8821c14092f2a9d3ef8a",
"version": "1.0.2",
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/hiredis/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/hiredis/vcpkg.json
Valid values for the license field can be found in the documentation
@dan-shaw Please don't remove the |
…jack/fix-hiredis-ssize_t-conflict
Co-authored-by: Billy O'Neal <bion@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for hiredis have changed but the version was not updated
version: 1.0.2#4
old SHA: f7763af93472b87cd743ed95d74f0d4a4361a700
new SHA: 448374fa990c04aa7964508d32817a6d7868600b
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
[hiredis] Fix the conflict of macro ssize_t (microsoft#25271)
When using hiredis and libuv at the same time, the definition of ssize_t will conflict:
In include/hiredis/hiredis.h line 34-47:
In include/hiredis/sds.h line 33-45:
In include/uv/win.h line 26-33:
Obviously, libuv restricts the redefinition of ssize_t, but hiredis does not.
Fix this.