Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lcm] use supports expression #25356

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Conversation

autoantwort
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:

  • ports/lcm/vcpkg.json (has deprecated license LGPL-2.1)

Deprecated and non deprecated license identifiers can be found here

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:

  • ports/lcm/vcpkg.json (has deprecated license LGPL-2.1+)

Deprecated and non deprecated license identifiers can be found here

@JonLiu1993 JonLiu1993 self-assigned this Jun 21, 2022
@JonLiu1993 JonLiu1993 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 21, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jun 22, 2022
@dan-shaw
Copy link
Contributor

The upstream library says it supports OSX. Or did I miss something?

@dan-shaw dan-shaw added requires:author-response info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines requires:author-response labels Jun 22, 2022
@dan-shaw dan-shaw merged commit 16e92b3 into microsoft:master Jun 23, 2022
@autoantwort autoantwort deleted the lcm-supports branch July 15, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants