Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dpdk] Update to version v22.03 #25374

Merged
merged 1 commit into from
Jul 2, 2022
Merged

[dpdk] Update to version v22.03 #25374

merged 1 commit into from
Jul 2, 2022

Conversation

ljishen
Copy link
Contributor

@ljishen ljishen commented Jun 21, 2022

Describe the pull request

  • What does your PR fix?

    Update dpdk to version v22.03

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    I've removed the x64-linux=fail from the file to mark that this port is supported by that Linux triplet.

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

github-actions[bot]
github-actions bot previously approved these changes Jun 21, 2022
@dg0yt
Copy link
Contributor

dg0yt commented Jun 22, 2022

I think both the old and the new attempt to provide a CMake config are full of problems. In addition, it is not from upstream, so it is should be in the unofficial namespace.

@Cheney-W Cheney-W added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Jun 22, 2022
@Cheney-W
Copy link
Contributor

@ljishen Could you please handle the failure in CI test? Failure log

@ljishen
Copy link
Contributor Author

ljishen commented Jun 23, 2022

@ljishen Could you please handle the failure in CI test? Failure log

The error is expected currently without the #25372. I've figured out how to separate static from dynamic build in dpdk according to @dg0yt's requirement. There is one more issue I need to fix before I can update this PR. Sorry about that.

github-actions[bot]
github-actions bot previously approved these changes Jun 23, 2022
@ljishen
Copy link
Contributor Author

ljishen commented Jun 23, 2022

@Cheney-W Is there a way to view the CI error log? Because I don't see failures in my local tests. I would like to see what's inside of /mnt/vcpkg-ci/buildtrees/dpdk/config-x64-linux-dbg-out.log reported by the CI.

github-actions[bot]
github-actions bot previously approved these changes Jun 24, 2022
@Cheney-W
Copy link
Contributor

Could you please open this: https://dev.azure.com/vcpkg/public/_build/results?buildId=74149&view=artifacts&pathAsName=false&type=publishedArtifacts ?
All failure logs are stored there.

github-actions[bot]
github-actions bot previously approved these changes Jun 24, 2022
@ljishen
Copy link
Contributor Author

ljishen commented Jun 24, 2022

Could you please open this: https://dev.azure.com/vcpkg/public/_build/results?buildId=74149&view=artifacts&pathAsName=false&type=publishedArtifacts ? All failure logs are stored there.

Thanks so much, @Cheney-W. This PR is ready to be reviewed.

@Cheney-W
Copy link
Contributor

Please remove the record about dpdk from ci.baseline.txt, because you have added "supports": "linux | freebsd" into the vcpkg.json file. Thank you!

github-actions[bot]
github-actions bot previously approved these changes Jun 24, 2022
@ljishen
Copy link
Contributor Author

ljishen commented Jun 24, 2022

@Cheney-W I've removed them. Please take a look. Thanks!

@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 24, 2022
@ljishen
Copy link
Contributor Author

ljishen commented Jun 25, 2022

@Cheney-W Is this PR ready to be merged? Thanks.

github-actions[bot]
github-actions bot previously approved these changes Jun 27, 2022
github-actions[bot]
github-actions bot previously approved these changes Jun 27, 2022
@Cheney-W Cheney-W added depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels Jun 28, 2022
ports/dpdk/portfile.cmake Outdated Show resolved Hide resolved
ports/dpdk/portfile.cmake Outdated Show resolved Hide resolved
@Cheney-W
Copy link
Contributor

Cheney-W commented Jul 1, 2022

@ljishen Could you please handle the suggestions of dg0yt?
Also, I don't think you should let a PR that hasn't been merged block your PR.

@ljishen
Copy link
Contributor Author

ljishen commented Jul 1, 2022

@ljishen Could you please handle the suggestions of dg0yt? Also, I don't think you should let a PR that hasn't been merged block your PR.

Great. Thanks for your support! I'll fix the code.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for dpdk have changed but the version was not updated
version: 22.03
old SHA: 4b1f50b8abd4b51bc126eaf5f3686d16caf6b0ff
new SHA: 17a389722a444ba5834d74a86717b6ee963be519
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed depends:different-pr This PR or Issue depends on a PR which has been filed requires:author-response labels Jul 1, 2022
@ljishen
Copy link
Contributor Author

ljishen commented Jul 1, 2022

@dan-shaw @dg0yt @Cheney-W Could you help to merge this one, please?

@dan-shaw dan-shaw merged commit 4826ede into microsoft:master Jul 2, 2022
@ljishen ljishen deleted the dpdk branch July 2, 2022 06:07
@autoantwort
Copy link
Contributor

autoantwort commented Jul 18, 2022

This package contains the following absolute path in include/rte_build_config.h:

#define RTE_EAL_PMD_PATH "/home/leander/vcpkg/packages/dpdk_x64-linux/lib/dpdk/pmds-22.1"

and it seems that this path is used in the code. The path is not existing when the package is restored from a binary cache. How should we handle this @ljishen?

@ljishen
Copy link
Contributor Author

ljishen commented Jul 19, 2022

@autoantwort With the linux triplet (e.g., x64-linux), this port will only build static libraries. The absolute path you asked contains dpdk's shared libraries and should be empty based on the triplet's requirement. Can you elaborate on the problem you have with that macro definition in the code? Did you have a customized triplet to use dpdk as a shared library?

@dg0yt
Copy link
Contributor

dg0yt commented Jul 19, 2022

Since 10 hours, there is now an x64-linux-dynamic community triplet.
And in general, there must be no absolute paths in vcpkg packages. They must be relocatable.

@ljishen
Copy link
Contributor Author

ljishen commented Jul 19, 2022

OK. I'll update the dpdk port to fix the absolute part problem.

@autoantwort
Copy link
Contributor

@ljishen Is there already a PR to fix the absolute path problem? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants