-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg script] Test pkg-config integration #25531
Conversation
95112c7
to
c5d90c5
Compare
Host
|
Don't need to care about it. System pkg-config is ok on !Windows. Windows users should update cmake any way. Main problem with current FindPkgConfig in vcpkg is that it doesn't support multi-config generators yet. We could do that with a wrapper installed alongside with pkgconf which does overrides the functions cmake normally uses and setup the targets correctlyy dependening on config. |
I mostly agree, but I don't want to decide for all users.
The problem with wrappers vs. port (I have a local branch which additonally uses the Ninja multi-config generator for this test-port, but I didn't see a benefit for |
scripts/test_ports/cmake-user/project/FindZLIBviaPkgConfig.cmake
Outdated
Show resolved
Hide resolved
I think vcpkg has the ability to provide usage information for pkg-config by now. |
What does your PR fix?
Test user-perceived
pkg-config
integration in vcpkg (find_package(PkgConfig)
,pkg_check_modules(...)
).Which triplets are supported/not supported? Have you updated the CI baseline?
all, no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?not needed.
Related
#22392 (comment)
#25529