-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ned14-internal-quickcpplib] Update port @2022-07-04 #25560
[ned14-internal-quickcpplib] Update port @2022-07-04 #25560
Conversation
I can't reproduce the linux build failure locally and I don't have access to an windows arm64 device. So I need access to the (cmake) build logs. |
You can click through from Checks to Azure pipelines to artifacts, and download the failure logs. The menu for download appears behind the three dots on the right side of an artifact, when the mouse is over that line. |
Ah, I missed the artifacts link, thank you. Ok, so the gcc version on linux is too old for I will set the Windows arm64 baseline to fail, because it is caused by an upstream bug ned14/quickcpplib#32 |
As an idea, for feedback from the core maintainers: A CI-only activation could be achieved via a test port (e.g. a new empty |
cc8d6a6
to
72eecab
Compare
@Adela0814 is this sufficient? |
Describe the pull request
What does your PR fix?
Updates quickcpplib, integrates the upstream dependency switch from
gsl-lite
tospan-lite
.Additionally I applied the feedback wrt polyfill features from [stduuid] Add new port @1.2.2 #25115
Which triplets are supported/not supported? Have you updated the CI baseline?
Set the Windows arm64 baseline to fail, because it is caused by an upstream bug algorithm/hash is incompatible with MSVC arm64 ned14/quickcpplib#32
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes