Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ned14-internal-quickcpplib] Update port @2022-07-04 #25560

Merged

Conversation

BurningEnlightenment
Copy link
Contributor

@BurningEnlightenment BurningEnlightenment commented Jul 4, 2022

Describe the pull request

github-actions[bot]
github-actions bot previously approved these changes Jul 4, 2022
@BurningEnlightenment
Copy link
Contributor Author

I can't reproduce the linux build failure locally and I don't have access to an windows arm64 device. So I need access to the (cmake) build logs.

@dg0yt
Copy link
Contributor

dg0yt commented Jul 5, 2022

I can't reproduce the linux build failure locally and I don't have access to an windows arm64 device. So I need access to the (cmake) build logs.

You can click through from Checks to Azure pipelines to artifacts, and download the failure logs. The menu for download appears behind the three dots on the right side of an artifact, when the mouse is over that line.

@Adela0814 Adela0814 added the category:port-update The issue is with a library, which is requesting update new revision label Jul 5, 2022
@BurningEnlightenment
Copy link
Contributor Author

BurningEnlightenment commented Jul 5, 2022

Ah, I missed the artifacts link, thank you.

Ok, so the gcc version on linux is too old for std::span and would need the polyfill-cxx20 feature. Is there a way to enable this just for the CI?

I will set the Windows arm64 baseline to fail, because it is caused by an upstream bug ned14/quickcpplib#32

@dg0yt
Copy link
Contributor

dg0yt commented Jul 5, 2022

Ok, so the gcc version on linux is too old for std::span and would need the polyfill-cxx20 feature. Is there a way to enable this just for the CI?

As an idea, for feedback from the core maintainers: A CI-only activation could be achieved via a test port (e.g. a new empty vcpkg-ci-polyfill port) in scripts/test-ports which depends on quickcpplib[polyfill-cxx20] for linux.

github-actions[bot]
github-actions bot previously approved these changes Jul 5, 2022
scripts/ci.baseline.txt Outdated Show resolved Hide resolved
@Adela0814 Adela0814 changed the title [quickcpplib] Update port @2022-07-04 [ned14-internal-quickcpplib] Update port @2022-07-04 Jul 8, 2022
@BurningEnlightenment
Copy link
Contributor Author

@Adela0814 is this sufficient?

@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 8, 2022
@vicroms vicroms merged commit 98f8d00 into microsoft:master Jul 8, 2022
@BurningEnlightenment BurningEnlightenment deleted the dev/ports/quickcpplib/2-update branch August 29, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants