Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crashpad] use vcpkg_cmake_get_vars #25864

Merged
merged 4 commits into from
Jul 25, 2022
Merged

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Jul 19, 2022

probably superseded by #23827

github-actions[bot]
github-actions bot previously approved these changes Jul 19, 2022
@Adela0814 Adela0814 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jul 20, 2022
ports/crashpad/vcpkg.json Show resolved Hide resolved
@Adela0814 Adela0814 added requires:author-response info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 21, 2022
@BillyONeal BillyONeal dismissed Adela0814’s stale review July 25, 2022 21:00

They marked info:reviewed so I assume this is OK

@BillyONeal BillyONeal merged commit 6b67ad7 into microsoft:master Jul 25, 2022
@BillyONeal
Copy link
Member

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants