[openssl] Enable builds with clang-cl #25869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
FrankXie05
added
the
category:port-feature
FrankXie05
previously approved these changes
Jul 22, 2022
|
@Neumann-A Is this PR ready for review? |
Yes. |
BillyONeal
dismissed stale reviews from FrankXie05 and github-actions
via
7fbbf7f
|
@Neumann-A Can you confirm that you are OK with the nitpick fix I pushed in 7fbbf7f ? |
BillyONeal
approved these changes
Jul 25, 2022
BillyONeal
added
requires:author-response
and removed
info:reviewed
LGTM. |
BillyONeal
added
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang always uses /Z7 so i deactivated the PDB install rules. Allowing /Z7 on normal windows requires removing /Zi /Fd from the internal build rules.