Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fluidsynth] Update to 2.2.8, improvements #25951

Merged
merged 5 commits into from
Jul 25, 2022
Merged

[fluidsynth] Update to 2.2.8, improvements #25951

merged 5 commits into from
Jul 25, 2022

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jul 24, 2022 •
edited

  • What does your PR fix?

    Updates fluidsynth to 2.2.8.
    Fixes broken sndfile feature control.
    Fixes broken pc file (cf. [vcpkg_fixup_pkgconfig] Check for more problems, add unit test #23898 (comment)).
    Re-integrates the (host) tool build into the main build, silencing a warning from vcpkg_cmake_configure.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    unchanged, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

github-actions[bot]
github-actions bot previously approved these changes Jul 24, 2022
View reviewed changes
@dg0yt dg0yt changed the title [fluidsynth] WIP [fluidsynth] Update to 2.2.8, improvements Jul 24, 2022
@dg0yt dg0yt marked this pull request as ready for review July 24, 2022 16:02
@JonLiu1993 JonLiu1993 added category:port-update The issue is with a library, which is requesting update new revision category:port-bug The issue is with a library, which is something the port should already support labels Jul 25, 2022
@JonLiu1993 JonLiu1993 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Jul 25, 2022
@JonLiu1993
Copy link
Member

All features are tested successfully in the following triplet:

x64-windows
x64-windows-static

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Jul 25, 2022
@BillyONeal BillyONeal merged commit d73287b into microsoft:master Jul 25, 2022
@BillyONeal
Copy link
Member

Thanks for the update :)

@dg0yt dg0yt deleted the fluidsynth branch July 25, 2022 19:33
@Cheney-W Cheney-W mentioned this pull request Aug 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions approved these changes

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dg0yt @JonLiu1993 @BillyONeal