Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdl2-ttf,tgui,sfml] Update sdl2-ttf to 2.20.0, revise dependencies import and export #26026

Merged
merged 58 commits into from
Aug 5, 2022

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Jul 28, 2022

Reprise of #25803 (@Thomas1664), #25713 (@FrankXie05). They made the major work.

  • What does your PR fix?

    Fixes [sdl2-ttf] update to 2.20.0 #25661.
    Modernizes tgui, and updates import and export of dependencies.
    Fixes and updates import and export of dependencies in port sfml, in particular OpenGL, needed for building tgui[tool]:x64-linux.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    unchanged, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

github-actions[bot]
github-actions bot previously approved these changes Jul 29, 2022
@dg0yt
Copy link
Contributor Author

dg0yt commented Jul 29, 2022

  • SFML is the default backend in TGUI. Using the SDL backend requires user to explicitly add
    #include <TGUI/Backends/SDL.hpp>.
  • The TGUI pc file isn't installed for all platforms, the given lib name doesn't match the actual file name for most configurations, and dependencies are completely missing.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for milerius-sfml-imgui have changed but the version was not updated
version: 1.1#5
old SHA: 9688f88e4f66e2c8ef9f40b45218ffb88d86e061
new SHA: ab049da96ffce2ca97cf13a61b4f2a657cb2d478
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/milerius-sfml-imgui/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Jul 29, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/milerius-sfml-imgui/vcpkg.json

Valid values for the license field can be found in the documentation

@dg0yt dg0yt marked this pull request as ready for review July 29, 2022 19:38
ports/tgui/portfile.cmake Show resolved Hide resolved
ports/sdl2-ttf/usage Show resolved Hide resolved
ports/tgui/usage Show resolved Hide resolved
ports/sdl2-ttf/usage Show resolved Hide resolved
@dg0yt
Copy link
Contributor Author

dg0yt commented Aug 3, 2022

@FrankXie05 Then please run with CMAKE_FIND_DEBUG_MODE enabled. I assume it is available, but not accepted due to some missing dependency.

@FrankXie05 FrankXie05 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Aug 4, 2022
@BillyONeal BillyONeal merged commit df806d3 into microsoft:master Aug 5, 2022
@BillyONeal
Copy link
Member

Thanks for the updates! (And also @Thomas1664 and @FrankXie05 )

@dg0yt dg0yt deleted the sdl2-ttf branch August 20, 2022 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdl2-ttf] update to 2.20.0
4 participants