[libpng] fix mips64 support #26265
[libpng] fix mips64 support #26265
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
FrankXie05
added
the
category:port-feature
| add_definitions(-DPNG_MIPS_MSA_OPT=2) | ||
| + if("${CMAKE_C_COMPILER_VERSION}" VERSION_GREATER_EQUAL "7") | ||
| + add_definitions(-D__mips_msa) | ||
| + add_compile_options(-mmsa -mhard-float -mfp64) |
There was a problem hiding this comment.
Why isn't this coming from the toolchain? I'm nervous about embedding assumptions about the target like this...
BillyONeal
added
requires:author-response
and removed
info:reviewed
|
Ping @Jamlys for response. |
Jamlys
requested review from
BillyONeal and
FrankXie05
and removed request for
BillyONeal and
FrankXie05
| if(${PNG_MIPS_MSA} STREQUAL "on") | ||
| add_definitions(-DPNG_MIPS_MSA_OPT=2) | ||
| + else() | ||
| + add_definitions(-DPNG_MIPS_MSA_CHECK_SUPPORTED) |
There was a problem hiding this comment.
Can you show that this has been submitted upstream and/or documentation from upstream that this is the correct thing to do?
(It looks correct to me but I'm very nervous about 'putting words in upstream's mouth')
There was a problem hiding this comment.
(To be clear, I'm not saying 'it has to be landed by upstream before we will land this', I'm saying that I think they have a right-of-first-refusal; as long as they have been notified and indicated agreement with the general direction, or have had some reasonable amount of time to respond, that's good enough)
There was a problem hiding this comment.
libpng has a simple specification about support for mips msa detection.
https://github.com/glennrp/libpng/tree/a37d4836519517bdce6cb9d956092321eca3e73b/contrib/mips-msa
While I looked into its configure file (starts at line 13610) for more detail about this.
https://github.com/glennrp/libpng/blob/a37d4836519517bdce6cb9d956092321eca3e73b/configure
There was a problem hiding this comment.
Those links don't work for me :/
JavierMatosD
added
requires:author-response
and removed
info:reviewed
BillyONeal
added
info:reviewed
|
Thanks! |
Add support for mips64.
What does your PR fix?
fix build failure for mips64.
Which triplets are supported/not supported? Have you updated the CI baseline?
linux, No
Does your PR follow the maintainer guide?
Basically.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/