[pixman] add mips64 support #26269
Merged
[pixman] add mips64 support #26269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Cheney-W
added
the
category:port-feature
Cheney-W
reviewed
Aug 10, 2022
ports/pixman/portfile.cmake
Outdated
Comment on lines
28
to
35
| -Dssse3=disabled | ||
| ) | ||
| elseif(VCPKG_TARGET_ARCHITECTURE MATCHES "mips") | ||
| list(APPEND OPTIONS | ||
| -Dmmx=disabled | ||
| -Dsse2=disabled | ||
| -Dssse3=disabled | ||
| ) |
There was a problem hiding this comment.
Suggested change
| -Dssse3=disabled | |
| ) | |
| elseif(VCPKG_TARGET_ARCHITECTURE MATCHES "mips") | |
| list(APPEND OPTIONS | |
| -Dmmx=disabled | |
| -Dsse2=disabled | |
| -Dssse3=disabled | |
| ) | |
| -Dssse3=disabled) | |
| elseif(VCPKG_TARGET_ARCHITECTURE MATCHES "mips") | |
| list(APPEND OPTIONS | |
| -Dmmx=disabled | |
| -Dsse2=disabled | |
| -Dssse3=disabled | |
| ) |
Just a suggestion, keep a consistent writing style.
added 2 commits
August 10, 2022 15:10
Cheney-W
added
info:reviewed
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for mips64.
What does your PR fix?
Fix build failure for mips64.
Which triplets are supported/not supported? Have you updated the CI baseline?
linux, No
Does your PR follow the maintainer guide?
Basically.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/