[matchit] Add first draft port #26499
Conversation
|
|
|
@daljit97 maybe the tests failed because you did not run ./vcpkg x-add-version --all? |
|
@BowenFu you're right I forgot to do that, but that doesn't seem to be the issue. The problem seems to be that the files matchitConfig.cmake and matchitConfigVersion.cmake aren't generated in the buildtree of vcpkg (they are when running cmake ordinarily). |
Cheney-W
changed the title
Cheney-W
added
the
category:new-port
|
@daljit97 maybe the problem is that make install was not supported in v1.0.0, will add new version v1.0.1 to fix this. |
|
If this is a header-only library, you can refer to this file to modify your PR. |
|
@BowenFu thanks indeed that seemed to be the issue (I probably should've checked against the 1.0.0 tag instead of head). I've tested on Linux and Windows and the port seems to work (at least locally). |
Previous commit incorrectly change the license for the port libzippp. This commit fixes that.
|
Glad to see the issue finally gets resolved. |
Change HEAD_REF to main Co-authored-by: Bowen Fu <BowenFu@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: Cheney Wang <38240633+Cheney-W@users.noreply.github.com>
Cheney-W
added
info:reviewed
|
Thank you! |
Add matchit, a library for pattern matching for C++17
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?I am still working on this PR