-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gdk-pixbuf] update to 2.42.9 #26534
Merged
JavierMatosD
merged 4 commits into
microsoft:master
from
PurpleFlowerGarden:2022-08-25-update-gdk-pixbuf-2.42.9
Aug 31, 2022
Merged
[gdk-pixbuf] update to 2.42.9 #26534
JavierMatosD
merged 4 commits into
microsoft:master
from
PurpleFlowerGarden:2022-08-25-update-gdk-pixbuf-2.42.9
Aug 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not running nor installing the test suite, so there's no point in building it, either
0fa3182
to
8d5dc99
Compare
The static build is broken on x64-windows with vc 2022. |
Fails to build over here. In fact, 2.42.8 also fails over here, so it's probably not a regression.
8d5dc99
to
172ff54
Compare
FrankXie05
requested changes
Aug 29, 2022
FrankXie05
approved these changes
Aug 30, 2022
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-update
The issue is with a library, which is requesting update new revision
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [gdk-pixbuf] update to 2.42.9 #26533
Which triplets are supported/not supported? Have you updated the CI baseline?
x64-windows-static
andx64-windows-static-md
have been broken before but where cascaded by glibs' inability to be built statically on those platforms, too. The CI baseline has been updated accordingly.Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/