Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gdk-pixbuf] update to 2.42.9 #26534

Conversation

SchaichAlonso
Copy link
Contributor

@SchaichAlonso SchaichAlonso commented Aug 26, 2022

Describe the pull request

  • What does your PR fix?

    Fixes [gdk-pixbuf] update to 2.42.9 #26533

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    x64-windows-static and x64-windows-static-md have been broken before but where cascaded by glibs' inability to be built statically on those platforms, too. The CI baseline has been updated accordingly.

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

We're not running nor installing the test suite, so there's no
point in building it, either
github-actions[bot]
github-actions bot previously approved these changes Aug 26, 2022
@FrankXie05 FrankXie05 self-assigned this Aug 26, 2022
@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 26, 2022
@SchaichAlonso SchaichAlonso force-pushed the 2022-08-25-update-gdk-pixbuf-2.42.9 branch from 0fa3182 to 8d5dc99 Compare August 26, 2022 20:10
github-actions[bot]
github-actions bot previously approved these changes Aug 26, 2022
@SchaichAlonso
Copy link
Contributor Author

The static build is broken on x64-windows with vc 2022.
Over here, it's also broken for version 2.42.8 which we currently have in master, despite lacking the ci.baseline.txt entry.

Fails to build over here. In fact, 2.42.8 also fails over here,
so it's probably not a regression.
@SchaichAlonso SchaichAlonso marked this pull request as ready for review August 26, 2022 23:19
scripts/ci.baseline.txt Show resolved Hide resolved
@FrankXie05 FrankXie05 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Aug 30, 2022
@JavierMatosD
Copy link
Contributor

Thank you!

@JavierMatosD JavierMatosD merged commit 87ed56c into microsoft:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gdk-pixbuf] update to 2.42.9
3 participants