Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[atk] fix supports #26700

Merged
merged 3 commits into from
Sep 7, 2022
Merged

[atk] fix supports #26700

merged 3 commits into from
Sep 7, 2022

Conversation

Adela0814
Copy link
Contributor

Fixes #26661

Error message:

Building package atk[core]:x64-windows-static...
-- Note: atk only supports dynamic library linkage. Building dynamic library.
CMake Error at scripts/cmake/vcpkg_check_linkage.cmake:25 (message):
  Refusing to build unexpected dynamic library against the static CRT.

@Adela0814 Adela0814 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Sep 6, 2022
github-actions[bot]
github-actions bot previously approved these changes Sep 6, 2022
View reviewed changes
Neumann-A
Neumann-A reviewed Sep 6, 2022
View reviewed changes
ports/atk/portfile.cmake Outdated Show resolved Hide resolved
Neumann-A
Neumann-A reviewed Sep 6, 2022
View reviewed changes
ports/atk/vcpkg.json Outdated Show resolved Hide resolved
@Adela0814 Adela0814 marked this pull request as ready for review September 7, 2022 06:34
github-actions[bot]
github-actions bot previously approved these changes Sep 7, 2022
View reviewed changes
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Sep 7, 2022
@dan-shaw dan-shaw merged commit cbd6d4a into microsoft:master Sep 7, 2022
@Thomas1664 Thomas1664 mentioned this pull request Sep 24, 2022
Closed
@Adela0814 Adela0814 deleted the Dev/Mengna/atk branch January 16, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@github-actions github-actions[bot] github-actions approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

atk:x64-windows-static build failure
5 participants
@Adela0814 @Neumann-A @JackBoosY @dan-shaw @JonLiu1993