Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glib]: fix pkgconfig tools path #26743

Merged
merged 2 commits into from
Sep 13, 2022
Merged

Conversation

theartful
Copy link
Contributor

Describe the pull request

This PR changes pkgconfig path of tools from "${bindir}/../tools" to "${prefix}/tools". On Linux, when using vcpkg manifest mode, the vcpkg installed dir usually doesn't have a bin directory. This leads to No such file or directory errors when using these variables, even though the full path exists.

@JonLiu1993 JonLiu1993 assigned Adela0814 and JonLiu1993 and unassigned Adela0814 Sep 13, 2022
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Sep 13, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Sep 13, 2022
@vicroms vicroms merged commit 88fe662 into microsoft:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants