[gdk-pixbuf]: fix pkgconfig tools path #26744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
theartful
force-pushed
the
gdkpixbuf_fix_pkgconf
branch
from
6dd2bcd
to
620aa3e
Compare
JackBoosY
added
the
category:port-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JackBoosY
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
LGTM.
The origin content in gdk-pixbuf-2.0.pc is :
prefix=F:/vcpkg/packages/gdk-pixbuf_x86-windows/debug
libdir=${prefix}/lib
includedir=${prefix}/../include
bindir=${prefix}/bin
gdk_pixbuf_binary_version=2.10.0
gdk_pixbuf_binarydir=${libdir}/gdk-pixbuf-2.0/2.10.0
gdk_pixbuf_moduledir=${gdk_pixbuf_binarydir}/loaders
gdk_pixbuf_cache_file=${gdk_pixbuf_binarydir}/loaders.cache
gdk_pixbuf_csource=${bindir}/gdk-pixbuf-csource
gdk_pixbuf_pixdata=${bindir}/gdk-pixbuf-pixdata
gdk_pixbuf_query_loaders=${bindir}/gdk-pixbuf-query-loaders
Name: GdkPixbuf
Description: Image loading and scaling
Version: 2.42.9
Requires: gobject-2.0 >= 2.56.0
Requires.private: glib-2.0 >= 2.56.0, gmodule-no-export-2.0 >= 2.56.0, gio-2.0 >= 2.56.0
Libs: -L${libdir} -lgdk_pixbuf-2.0
Libs.private: -lintl F:/vcpkg/installed/x86-windows/debug/lib/libpng16d.lib F:/vcpkg/installed/x86-windows/debug/lib/zlibd.lib F:/vcpkg/installed/x86-windows/debug/lib/jpeg.lib F:/vcpkg/installed/x86-windows/debug/lib/tiffd.lib F:/vcpkg/installed/x86-windows/debug/lib/libpng16d.lib F:/vcpkg/installed/x86-windows/debug/lib/zlibd.lib F:/vcpkg/installed/x86-windows/debug/lib/jpeg.lib F:/vcpkg/installed/x86-windows/debug/lib/tiffd.lib F:/vcpkg/installed/x86-windows/debug/lib/libpng16d.lib F:/vcpkg/installed/x86-windows/debug/lib/zlibd.lib F:/vcpkg/installed/x86-windows/debug/lib/jpeg.lib F:/vcpkg/installed/x86-windows/debug/lib/tiffd.lib F:/vcpkg/installed/x86-windows/debug/lib/libpng16d.lib F:/vcpkg/installed/x86-windows/debug/lib/zlibd.lib F:/vcpkg/installed/x86-windows/debug/lib/jpeg.lib F:/vcpkg/installed/x86-windows/debug/lib/tiffd.lib F:/vcpkg/installed/x86-windows/debug/lib/libpng16d.lib F:/vcpkg/installed/x86-windows/debug/lib/zlibd.lib F:/vcpkg/installed/x86-windows/debug/lib/jpeg.lib F:/vcpkg/installed/x86-windows/debug/lib/tiffd.lib F:/vcpkg/installed/x86-windows/debug/lib/libpng16d.lib F:/vcpkg/installed/x86-windows/debug/lib/zlibd.lib F:/vcpkg/installed/x86-windows/debug/lib/jpeg.lib F:/vcpkg/installed/x86-windows/debug/lib/tiffd.lib F:/vcpkg/installed/x86-windows/debug/lib/libpng16d.lib F:/vcpkg/installed/x86-windows/debug/lib/zlibd.lib F:/vcpkg/installed/x86-windows/debug/lib/jpeg.lib F:/vcpkg/installed/x86-windows/debug/lib/tiffd.lib F:/vcpkg/installed/x86-windows/debug/lib/libpng16d.lib F:/vcpkg/installed/x86-windows/debug/lib/zlibd.lib F:/vcpkg/installed/x86-windows/debug/lib/jpeg.lib F:/vcpkg/installed/x86-windows/debug/lib/tiffd.lib F:/vcpkg/installed/x86-windows/debug/lib/libpng16d.lib F:/vcpkg/installed/x86-windows/debug/lib/zlibd.lib F:/vcpkg/installed/x86-windows/debug/lib/jpeg.lib F:/vcpkg/installed/x86-windows/debug/lib/tiffd.lib F:/vcpkg/installed/x86-windows/debug/lib/libpng16d.lib F:/vcpkg/installed/x86-windows/debug/lib/zlibd.lib F:/vcpkg/installed/x86-windows/debug/lib/jpeg.lib F:/vcpkg/installed/x86-windows/debug/lib/tiffd.lib F:/vcpkg/installed/x86-windows/debug/lib/libpng16d.lib F:/vcpkg/installed/x86-windows/debug/lib/zlibd.lib F:/vcpkg/installed/x86-windows/debug/lib/jpeg.lib F:/vcpkg/installed/x86-windows/debug/lib/tiffd.lib F:/vcpkg/installed/x86-windows/debug/lib/libpng16d.lib F:/vcpkg/installed/x86-windows/debug/lib/zlibd.lib F:/vcpkg/installed/x86-windows/debug/lib/jpeg.lib F:/vcpkg/installed/x86-windows/debug/lib/tiffd.lib F:/vcpkg/installed/x86-windows/debug/lib/libpng16d.lib F:/vcpkg/installed/x86-windows/debug/lib/zlibd.lib F:/vcpkg/installed/x86-windows/debug/lib/jpeg.lib F:/vcpkg/installed/x86-windows/debug/lib/tiffd.lib
Cflags: -I${includedir}/gdk-pixbuf-2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR changes pkgconfig path of tools from "${bindir}/../tools" to "${prefix}/tools". On Linux, when using vcpkg manifest mode, the vcpkg installed dir usually doesn't have a
bindirectory. This leads toNo such file or directoryerrors when using these variables, even though the full path exists.Also,
gdk_pixbuf_binarydirwas set correctly in the first place and was incorrectly changed.