Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] GENERATOR with Makefiles can build parallel #26780

Merged
merged 7 commits into from Oct 9, 2022
Merged

[vcpkg] GENERATOR with Makefiles can build parallel #26780

merged 7 commits into from Oct 9, 2022

Conversation

day253
Copy link
Contributor

@day253 day253 commented Sep 13, 2022 •
edited

Describe the pull request

outdated PR #26596

I think the break change was related to #23259

@day253 day253 mentioned this pull request Sep 13, 2022
Closed
JackBoosY
JackBoosY previously approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@JackBoosY JackBoosY added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Sep 14, 2022
@JackBoosY JackBoosY marked this pull request as ready for review September 14, 2022 02:33
@JackBoosY
Copy link
Contributor

JackBoosY commented Sep 14, 2022 •
edited

I will track the regressions.
Some regressions will be fixed in #26771 and #26646

@day253
Copy link
Contributor Author

day253 commented Sep 14, 2022

I will track the regressions. Some regressions will be fixed in #26771 and #26646

Thanks!

@JackBoosY
Copy link
Contributor

JackBoosY commented Sep 14, 2022 •
edited

@JackBoosY JackBoosY mentioned this pull request Sep 14, 2022
Merged
@m-kuhn m-kuhn mentioned this pull request Sep 14, 2022
Closed
@JackBoosY
Copy link
Contributor

It looks that we only have saucer regression, so please wait for #26783 merge first.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Sep 15, 2022
@day253
Copy link
Contributor Author

day253 commented Sep 15, 2022

#26783

No problem.

@JackBoosY JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Sep 16, 2022
@JackBoosY JackBoosY mentioned this pull request Sep 16, 2022
Merged
@JackBoosY JackBoosY added depends:different-pr This PR or Issue depends on a PR which has been filed and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Sep 19, 2022
github-actions[bot]
github-actions bot previously approved these changes Sep 20, 2022
View reviewed changes
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Sep 22, 2022
vicroms
vicroms previously approved these changes Sep 26, 2022
View reviewed changes
@vicroms
Copy link
Member

vicroms commented Sep 26, 2022

Approved but not merged. I tried fixing the merge conflicts but don't have permission to push to your repo.

@vicroms vicroms added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Sep 26, 2022
@day253
Copy link
Contributor Author

day253 commented Sep 27, 2022

Approved but not merged. I tried fixing the merge conflicts but don't have permission to push to your repo.

I will fix the conflicts today.

@day253 day253 requested review from vicroms and JackBoosY and removed request for vicroms and JackBoosY September 27, 2022 09:24
@day253
Copy link
Contributor Author

day253 commented Oct 7, 2022

Approved but not merged. I tried fixing the merge conflicts but don't have permission to push to your repo.

I will fix the conflicts today.

@vicroms @JackBoosY I add you two as members of my repo. I merged the master branch into my branch. All tests have passed.

@day253 day253 requested review from JackBoosY and removed request for vicroms October 8, 2022 07:36
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Oct 8, 2022
@vicroms vicroms merged commit 11967e7 into microsoft:master Oct 9, 2022
@day253 day253 deleted the parallel_build branch October 9, 2022 04:51
@JackBoosY
Copy link
Contributor

Thanks for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

@vicroms vicroms vicroms left review comments

Assignees

@JackBoosY JackBoosY

Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[vcpkg] GENERATOR with Makefiles can build parallel
3 participants
@day253 @JackBoosY @vicroms