Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grpc] Update to 1.49.0 #26836

Merged
merged 5 commits into from
Sep 26, 2022
Merged

[grpc] Update to 1.49.0 #26836

merged 5 commits into from
Sep 26, 2022

Conversation

Tradias
Copy link
Contributor

@Tradias Tradias commented Sep 16, 2022

  • What does your PR fix?

    Fixes [grpc] update to 1.49.0 #26808

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, yes

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

github-actions[bot]
github-actions bot previously approved these changes Sep 16, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the version scheme "version" instead of "version-string" in port "abseil".

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/abseil/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the version scheme "version" instead of "version-string" in port "abseil".

@Tradias
Copy link
Contributor Author

Tradias commented Sep 17, 2022

I have tested the features abseil[cxx17] and grpc[codegen] in the triplets:

  • x64-windows
  • x64-windows-static

I think the arm64_windows pipeline just had a hiccup. ffmpeg should not be affected by the changes in this pull request in any way.

@Tradias Tradias marked this pull request as ready for review September 17, 2022 09:35
@JonLiu1993 JonLiu1993 self-assigned this Sep 19, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 19, 2022
@JonLiu1993
Copy link
Member

grpc、upb、abseil:
All features are tested successfuly in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Sep 19, 2022
@dan-shaw dan-shaw added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Sep 21, 2022
@dan-shaw dan-shaw merged commit 5f6a2ed into microsoft:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[grpc] update to 1.49.0
3 participants