Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hpx] no absolute paths #27035

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Conversation

autoantwort
Copy link
Contributor

For #20469

@Neumann-A Or is this file needed?

github-actions[bot]
github-actions bot previously approved these changes Sep 29, 2022
@Neumann-A
Copy link
Contributor

please keep hpxrun since it is a helper to run hpx applications

hpxcxx can be removed. That is just a helper to build hpx applications which seems unnecessary if CMake/PkgConfig is used.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for hpx have changed but the version was not updated
version: 1.8.0#2
old SHA: 13600ed4ca6096a2b96019121935ff06fc35fd7f
new SHA: 769d8dc0d22df04f39b283990b8a63426d6fee6e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Sep 29, 2022
ports/hpx/portfile.cmake Outdated Show resolved Hide resolved
@FrankXie05 FrankXie05 added the category:port-bug The issue is with a library, which is something the port should already support label Sep 30, 2022
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Sep 30, 2022
@vicroms vicroms merged commit 1d3eafa into microsoft:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants