Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[osgearth] Plugin installation fixes #27156

Merged
merged 4 commits into from
Oct 12, 2022
Merged

[osgearth] Plugin installation fixes #27156

merged 4 commits into from
Oct 12, 2022

Conversation

cbrl
Copy link
Contributor

@cbrl cbrl commented Oct 9, 2022

Describe the pull request

  • What does your PR fix?

    Fixes the installation of osgEarth plugins, similar to [osg] Fix plugin installation and target locations #26214 with the osg plugins. Plugins are handled here in the same way they are with osg, so the changes and effects with this PR are nearly identical.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All, no.

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

This change has the same effects and reasoning as the prior fix to the osg port.
@LilyWangLL LilyWangLL self-assigned this Oct 10, 2022
@LilyWangLL LilyWangLL added the category:port-bug The issue is with a library, which is something the port should already support label Oct 10, 2022
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Oct 10, 2022
@vicroms vicroms merged commit 13d47a6 into microsoft:master Oct 12, 2022
@cbrl cbrl deleted the osgearth branch November 6, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants