[python3] Fix compilation of built-in modules on older versions of GCC #27201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Cheney-W
added
depends:upstream-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #26573. I can confirm that the build failures reported in this issue no longer happen with the changes from this PR.
The problem underlying this issue was that on Linux, vcpkg seems to report the used compiler to Python as
cc -pthread, however, the compilerccis not recognized by distuilts as an alias ofg++.I also opened a PR in the upstream project (python/cpython#98220). I hope this fix will be included in future releases of Python, but until this is the case, vcpkg can use this PR to patch the source code of current Python releases to avoid build errors with older versions of GCC.
What does your PR fix?
Fixes [python3] build failure on GCC <= 9.4 #26573.
Which triplets are supported/not supported? Have you updated the CI baseline?
All, no
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes