-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qhull] Disable tools install on iOS #27379
Conversation
There is #27260. |
Yeah that's a cleaner solution, but it's waiting on upstream, and who knows when the next Qhull version will be released. |
TBH I don't why the other PR is requested to wait. Of couse that patch could be minimized, without the formatting changes. |
We aren't qhull, we are a packaging solution, so we don't want to speak for them. Some patch principles:
That PR adds a new deployment scheme / knob, so we believe upstream needs an opportunity to weigh in. It's a build system feature and not a product feature, we're willing to take the patch if they don't respond. |
@BillyONeal Considering that #27386 says
Does this PR actually need to wait on upstream? The tools are irrelevant on iOS. There is #27260 that can supersede this if upstream agrees to take in changes to disable the tools build. This is only avoids installing them to avoid a bug at the last moment possible. |
That has been merged. Do you still want this change? |
No real need for this PR with the other one merged. |
CMake doesn't generate usable tool executables when cross-compiling to iOS, and the install step is broken due to invalid paths in the targets file.
What does your PR fix?
Skip installing the iOS tools, they don't run and there's no real use for them anyway.
Which triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?yes