Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libpq] fix build with non-English MSVC (#26921) #27851

Merged
merged 3 commits into from
Nov 18, 2022
Merged

[libpq] fix build with non-English MSVC (#26921) #27851

merged 3 commits into from
Nov 18, 2022

Conversation

ArcticLampyrid
Copy link
Contributor

@ArcticLampyrid
Copy link
Contributor Author

With Chinese language pack, we'll get

用于 x64 的 Microsoft (R) C/C++ 优化编译器 19.33.31630 版

The keyword x64 is not at the end of a line.

@FrankXie05 FrankXie05 added the category:port-bug The issue is with a library, which is something the port should already support label Nov 17, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libpq have changed but the version was not updated
version: 14.4#2
old SHA: d452cd83bf4c62032f2ecbf66b23d75261f6ed88
new SHA: ff1fb58229c0d2759dd872d5187ad8c0b29f46de
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@ArcticLampyrid
Copy link
Contributor Author

@microsoft-github-policy-service agree

@FrankXie05
Copy link
Contributor

@gamesyule Could you test this PR?

@dg0yt
Copy link
Contributor

dg0yt commented Nov 18, 2022

Note that the English language pack is a documented requirement for vcpkg. Even if this port is fixed, you are likely to run into trouble with other ports.
https://github.com/microsoft/vcpkg#quick-start-windows

@BillyONeal
Copy link
Member

Note that the English language pack is a documented requirement for vcpkg.

We need to fix that if we want to go 'in the box' :)

@BillyONeal BillyONeal merged commit 28324ed into microsoft:master Nov 18, 2022
@BillyONeal
Copy link
Member

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libpq] build failure
4 participants