-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libpq] fix build with non-English MSVC (#26921) #27851
Conversation
With Chinese language pack, we'll get
The keyword |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for libpq have changed but the version was not updated
version: 14.4#2
old SHA: d452cd83bf4c62032f2ecbf66b23d75261f6ed88
new SHA: ff1fb58229c0d2759dd872d5187ad8c0b29f46de
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
@microsoft-github-policy-service agree |
@gamesyule Could you test this PR? |
Note that the English language pack is a documented requirement for vcpkg. Even if this port is fixed, you are likely to run into trouble with other ports. |
We need to fix that if we want to go 'in the box' :) |
Thanks for the fix! |
What does your PR fix?
Fixes [libpq] build failure #26921
Does your PR follow the maintainer guide?
Yes