-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libpng] Fix libpng for android #28018
Conversation
The failures on CI are known and they are being fixed.
Is this only implemented on top of the latest? So if it's not the latest, will your changes cause other errors? |
Digging deeper... The upstream logic actually has a dependency on the target architecture: https://github.com/glennrp/libpng/blob/libpng16/CMakeLists.txt#L95-L104 This should be updated to switch to |
FTR a similar PR was reviewed in #27936. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
adb7161
to
7461aa3
Compare
Should be fine now |
Thank you! |
Describe the problem
check
is only a valid value for arm architectures.On
arm64
this errors withDescribe the pull request
Only use
check
onarm