Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lz4] update to 1.9.4 #28348

Merged
merged 1 commit into from
Jan 4, 2023
Merged

[lz4] update to 1.9.4 #28348

merged 1 commit into from
Jan 4, 2023

Conversation

kobykahane
Copy link
Contributor

  • Update the lz4 port to upstream release 1.9.4.
  • Remove now-upstreamed patch.

lz4 1.9.4 includes upstream PR lz4/lz4#1054 which is required for successful compilation for arm64ec once #27814 is merged.

Verified successful build with x64-windows-static, x86-windows-static and arm64-windows-static.

@JonLiu1993 JonLiu1993 self-assigned this Dec 15, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Dec 15, 2022
@kobykahane kobykahane marked this pull request as ready for review December 15, 2022 10:05
github-actions[bot]
github-actions bot previously approved these changes Dec 20, 2022
github-actions[bot]
github-actions bot previously approved these changes Dec 28, 2022
@JonLiu1993
Copy link
Member

JonLiu1993 commented Dec 29, 2022

@dg0yt
Copy link
Contributor

dg0yt commented Dec 29, 2022

From config.log:

pkg_cv_LZ4_LIBS='-L -llz4d'

There is something wrong with the Libs line in [debug/]lib/pkgconfig/liblz4.pc.

@kobykahane
Copy link
Contributor Author

From config.log:

pkg_cv_LZ4_LIBS='-L -llz4d'

There is something wrong with the Libs line in [debug/]lib/pkgconfig/liblz4.pc.

Thanks.

The issue appears to have originated in upstream commit lz4/lz4@c1f514f.
Fixed by modifying the configure_file invocation in CMakeLists.txt to have @ONLY to avoid incorrectly substituting ${libdir} in addition to @LIBDIR@ with the contents of CMake variable LIBDIR.

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jan 3, 2023
@vicroms vicroms merged commit 623771e into microsoft:master Jan 4, 2023
@kobykahane kobykahane deleted the lz4_1_9_4 branch January 4, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants