Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boost-locale] fix icu feature #28504

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Conversation

quyykk
Copy link
Contributor

@quyykk quyykk commented Dec 22, 2022

  • What does your PR fix?

Fixes the icu feature of [boost-locale].

  • Which triplets are supported/not supported? Have you updated the CI baseline?

same as before

yeah

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yeah

@Adela0814 Adela0814 added category:port-bug The issue is with a library, which is something the port should already support requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Dec 23, 2022
@YunchengLiu
Copy link

Hi, I would like to ask when will this PR be merged into it? I'm waiting for this to fix the problem~

@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function labels Dec 29, 2022
@vicroms vicroms merged commit 39bba54 into microsoft:master Dec 29, 2022
@quyykk quyykk deleted the fix-boost-locale-icu branch December 29, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants