Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqlite-orm] Update SQLite ORM to 1.8 #28988

Merged
merged 9 commits into from
Jan 31, 2023

Conversation

trueqbit
Copy link
Contributor

@trueqbit trueqbit commented Jan 16, 2023

Describe the pull request

  • What does your PR fix?

    Updates SQLite ORM [sqlite-orm] to v1.8.1.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    CI baseline updated.
    tested triplets: sqlite-orm[core,example,test]:x64-windows, sqlite-orm[core,example,test]:x86-windows, sqlite-orm[core,example]:x64-windows-v140

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

github-actions[bot]
github-actions bot previously approved these changes Jan 16, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/sqlite-orm/vcpkg.json

Valid values for the license field can be found in the documentation

@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Jan 17, 2023
LilyWangLL
LilyWangLL previously approved these changes Jan 17, 2023
@trueqbit
Copy link
Contributor Author

Waiting for fnc12/sqlite_orm#1125

@trueqbit trueqbit marked this pull request as ready for review January 28, 2023 17:58
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for sqlite-orm have changed but the version was not updated
version: 1.8.1
old SHA: a120f5c5e79bdce818865ccfe2883c8e5296aaeb
new SHA: 4d11317c518c21a1f7bf2834f2a5d00d52879edf
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider replacing the deprecated license identifiers in the following files:

  • ports/sqlite-orm/vcpkg.json (has deprecated license GPL-3.0)

Deprecated and non deprecated license identifiers can be found here

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for sqlite-orm have changed but the version was not updated
version: 1.8.1
old SHA: a120f5c5e79bdce818865ccfe2883c8e5296aaeb
new SHA: cbb80bd62fb69f81d00cc551f1033b31df52ca2d
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@trueqbit
Copy link
Contributor Author

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for sqlite-orm have changed but the version was not updated
version: 1.8.1
old SHA: a120f5c5e79bdce818865ccfe2883c8e5296aaeb
new SHA: cbb80bd62fb69f81d00cc551f1033b31df52ca2d
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

I don't quite understand the problem. Is it the two commits in the PR that change the version? Do I need to create another PR that combines all the changes?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for sqlite-orm have changed but the version was not updated
version: 1.8.1
old SHA: a120f5c5e79bdce818865ccfe2883c8e5296aaeb
new SHA: cbb80bd62fb69f81d00cc551f1033b31df52ca2d
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@LilyWangLL
Copy link
Contributor

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for sqlite-orm have changed but the version was not updated
version: 1.8.1
old SHA: a120f5c5e79bdce818865ccfe2883c8e5296aaeb
new SHA: cbb80bd62fb69f81d00cc551f1033b31df52ca2d
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

I don't quite understand the problem. Is it the two commits in the PR that change the version? Do I need to create another PR that combines all the changes?

You need change SHA in file [VCPKG_ROOT]/versions/s-/sqlite-orm.json.

 old SHA: a120f5c5e79bdce818865ccfe2883c8e5296aaeb
 new SHA: cbb80bd62fb69f81d00cc551f1033b31df52ca2d

image

github-actions[bot]
github-actions bot previously approved these changes Jan 29, 2023
versions/s-/sqlite-orm.json Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jan 30, 2023
@BillyONeal BillyONeal merged commit b4f29c5 into microsoft:master Jan 31, 2023
@BillyONeal
Copy link
Member

Thanks for the update!

@trueqbit trueqbit deleted the sqlite-orm_18 branch January 31, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants