Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[faad2] Update to 2.10.1 #29319

Merged
merged 2 commits into from
Feb 2, 2023
Merged

[faad2] Update to 2.10.1 #29319

merged 2 commits into from
Feb 2, 2023

Conversation

Cheney-W
Copy link
Contributor

@Cheney-W Cheney-W commented Jan 31, 2023 •
edited
Loading

Fixes #29185.
Fixes faad_decoder.exe is not installed when installing faad2[build-decoder].

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

All features passed with following triplets:
x86-windows
x64-windows
x64-windows-static

@Cheney-W Cheney-W added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Jan 31, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 31, 2023
View reviewed changes
@Cheney-W Cheney-W marked this pull request as ready for review January 31, 2023 10:06
@BillyONeal
Copy link
Member

I manually checked that the SHA in here is not affected by #29288

@Cheney-W Cheney-W added the category:port-bug The issue is with a library, which is something the port should already support label Feb 1, 2023
@BillyONeal BillyONeal added the info:reviewed Pull Request changes follow basic guidelines label Feb 1, 2023
@BillyONeal BillyONeal merged commit c35b816 into microsoft:master Feb 2, 2023
@BillyONeal
Copy link
Member

Thanks for the update!

@Cheney-W Cheney-W deleted the Dev/Cheney/29185 branch February 3, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@github-actions github-actions[bot] github-actions approved these changes

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[faad2] update to 2.10.1
3 participants
@Cheney-W @BillyONeal @LilyWangLL