[icu] Add host tool path #29329
Merged
[icu] Add host tool path #29329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
m-kuhn
changed the title
MonicaLiu0311
added
the
category:port-bug
works fine for me |
dg0yt
reviewed
Feb 6, 2023
ports/icu/portfile.cmake
Outdated
Comment on lines
45
to
49
| set(TOOL_PATH "${CURRENT_HOST_INSTALLED_DIR}/tools/${PORT}") | ||
| if(CMAKE_HOST_WIN32 AND VCPKG_TARGET_IS_MINGW AND NOT HOST_TRIPLET MATCHES "mingw") | ||
| # Assuming no cross compiling because the host (windows) pkgdata tool doesn't | ||
| # use the '/' path separator when creating compiler commands for mingw bash. | ||
| elseif(VCPKG_CROSSCOMPILING) | ||
| set(TOOL_PATH "${CURRENT_HOST_INSTALLED_DIR}/tools/${PORT}") |
There was a problem hiding this comment.
Does this line need to be moved? AFAICS it is only used near the old location.
There was a problem hiding this comment.
I assumed x86-windows or x64-linux-dynamic are not crosscompiling but will still need the host tool path set to build. However, looking at it again now it seems that the build succeeded and only the copy command failed.
Will revert
MonicaLiu0311
approved these changes
Feb 7, 2023
MonicaLiu0311
added
the
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29322