Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skia] Fix vulkan #29448

Merged
merged 2 commits into from
Feb 6, 2023
Merged

[skia] Fix vulkan #29448

merged 2 commits into from
Feb 6, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Feb 4, 2023

Fixes #29367

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

github-actions[bot]
github-actions bot previously approved these changes Feb 4, 2023
View reviewed changes
This was referenced Feb 4, 2023
Closed
Closed
@Cheney-W Cheney-W self-assigned this Feb 6, 2023
@Cheney-W Cheney-W added the category:port-bug The issue is with a library, which is something the port should already support label Feb 6, 2023
@Cheney-W
Copy link
Contributor

Cheney-W commented Feb 6, 2023

skia[vulkan] install passed with following triplets:
x86-windows
x64-windows
x64-windows-static

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Feb 6, 2023
@JavierMatosD JavierMatosD merged commit 873263a into microsoft:master Feb 6, 2023
@dg0yt dg0yt deleted the skia branch February 6, 2023 20:00
@FrankXie05 FrankXie05 mentioned this pull request May 8, 2023
Closed
@dg0yt dg0yt mentioned this pull request Jul 25, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheney-W Cheney-W Cheney-W approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[skia] build failure
3 participants
@dg0yt @Cheney-W @JavierMatosD